PS6136: detect retained maximum-context output workspace - #1013
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Related #887.
Register opt-in advisory PS6136 for maximum-context retained output workspace. Prove selected GPT/Llama constructor ownership, model/head width, complete output observations, one-row common execution and actualRows-times-width bulk execution. Report retained/common/idle bytes and amplification; no automatic lifetime-changing rewrite.
Replay complete authentic GoAI PR1207 sources: before
a10a6bff8f7cb0adf695742b6ec677b750b03c28, after40bf79ae7d93caa9384719c779d38b6ae4aaa8a1. Both original selected constructors report once; both changed constructors remain quiet. The compiler fixture includes all 28 shared and two GPT constructor functions and the profiling API; native/model type scaffolds are explicitly distinguished from authentic source.Boundaries
Inventory profiling, pending work, constructor/field exposures and fallback paths. Distinguish capacity-wide physical ToHost transfer from first-Vocab logical consumption. Unselected architectures remain silent. Native ownership/completion/external semantics and workload policy require precise reviewed contracts. Full logical consumption or hard-real-time growth prohibition suppresses advice. Measurements are attributed owner results, not new native measurements or universal speed predictions.
Independent local review covered typed receiver identity, successful allocation/error/release paths, invocation-specific aliases and recorder origins, effectful host-copy destinations, and actual bulk extent evidence. The retained adversarial controls exercise each repaired gap. Unknown effects and unclassified observations fail closed.
A final review found and repaired a real initialization-order false positive: correct eventual owner fields do not establish the earlier allocation geometry. Every selected maximum-row/width load must follow its unique initializer, including exact helper/callback invocation boundaries; a helper write must precede all executable returns. Four authentic-source late/conditional initializer mutations first reproduced registered findings and now reject at the intended gate. Rewritten compiler fixtures are fully reprinted/reparsed with source positions and comments so negative tests cannot pass vacuously because of injected positionless AST nodes.
Validation
422b759ce0869ae786cea1ed73e6024a28a8299d, preserving published0f2ff90and authored0ca8ad2ancestry without history rewriting.422b759ce0869ae786cea1ed73e6024a28a8299dand the worktree is clean.161891e8d4f8eff61c8b36885f26658a39e6aa18was independently verified green on all 14 jobs before merging.Merged normally at 2026-09-12 19:46:08 UTC as
8a64e6a25a6ca0e0280277bb8e1ab34759e1b5e5, with exact-head matching and no bypass. Issue #887 remains open until the resulting default-branch CI is green.