fix: require PS6136 retention before successful publication - #1014
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Require the exact retention append-store to dominate successful buffer-slot publication in PS6136. Finding a conditional append somewhere in the factory is not enough to prove that the returned buffer remains in the owner's retained list.
Parallel regression controls retain the genuine typed allocator/result/owner prerequisites and cover unconditional retention plus both conditional-append branches. Empty early-error returns remain supported; no tests are removed or weakened.
Validation
The false admission was reproduced on the default-branch source before applying the fix. Independent local source review and focused repeated race tests passed. The normal pre-commit gate passed all 2,003 tests and the self-scan. The normal pre-push gate also passed: formatting, vet, build, all parallel race tests, staticcheck, generated docs, plugin build, benchmark smoke tests and self-scan.
This is a correctness follow-up to the retained-workspace analysis, discovered during issue #890. That detector remains unfinished and requires its own implementation, review, PR and CI validation.