Repository navigation
Preserve values for map keys containing NaN - #119
Merged
Merged
Conversation
k0kubun
reviewed
Oct 21, 2026
Owner
There was a problem hiding this comment.
How about renaming this to sort_test.go to clarify that it's testing sort.go?
Owner
There was a problem hiding this comment.
To save your time, I'll do so myself here.
k0kubun
approved these changes
Oct 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Iterate over map entries directly when collecting sorted keys and values. Looking up each key again with
MapIndexloses values for non-reflexive keys, such as NaN, and printsnilinstead.The regression fails before the fix for float, complex and array keys containing NaN. Full tests, vet and changed-file gofmt pass.