Backport fix(golang-adk): resolve user identity from A2A call context to 0.10.x - #2507
Open
buravc wants to merge 4 commits into
Open
Backport fix(golang-adk): resolve user identity from A2A call context to 0.10.x#2507buravc wants to merge 4 commits into
buravc wants to merge 4 commits into
Conversation
userIDInterceptor.Before runs before a2a-go v0.3.15 forks execution and persistence into separate goroutines. Putting the user id on ctx there, instead of only on the CallContext, means both goroutines see it. Execute now reads it via auth.UserIDFromContext instead of the CallContext, which the persistence goroutine never had access to. Signed-off-by: buravc <avcii.brk@gmail.com>
Verified this test fails without the fix (returned ctx has no user id). Signed-off-by: buravc <avcii.brk@gmail.com>
supreme-gg-gg
approved these changes
Aug 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AI Disclosure: This PR was created with an AI agent under my supervision.
Fixes #2443
This PR fixes task/chat history disappearing after 0.10 upgrade.
Backport of #2449