Repository navigation
Fix window geometry restoration bug - #13990
Merged
Merged
Conversation
This was referenced Nov 2, 2026
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #13990 +/- ##
===========================================
- Coverage 61.22% 61.19% -0.03%
===========================================
Files 396 396
Lines 37922 37926 +4
===========================================
- Hits 23216 23208 -8
- Misses 14706 14718 +12 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Sometimes KeePassXC did not restore the window geometry properly. This change moves the geometry restoration to before showing the window. That should fix issues especially when the window is moved to another monitor on Wayland, but it may also resolve other strange quirks that can happen when the window starts in the tray.
phoerious
force-pushed
the
fix/window-restore-geometry
branch
from
November 2, 2026 14:12
41ec1d2 to
5b989ae
Compare
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
A remaining active finding identifies missing GUI coverage for the one-time persisted geometry/state restore path, leaving a regression in this Wayland-sensitive behavior undetected by the existing tests.
No open issues 🎉
2 resolved since last review
Review effort: Lite
droidmonkey
approved these changes
Nov 2, 2026
Member
|
Nice fix! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sometimes KeePassXC did not restore the window geometry properly. This change moves the geometry restoration to before showing the window. That should fix issues especially when the window is moved to another monitor on Wayland, but it may also resolve other strange quirks that can happen when the window starts in the tray.
Fixes #12044 (as a side effect)
Also fixes GUI tests using your actual local config file.
Testing strategy
Works now on my second monitor on Wayland. Before, KeePassXC always started with an 800x600px window.
Type of change