Add Windows guest networking - #432
Open
sjmiller609 wants to merge 6 commits into
Open
Conversation
sjmiller609
force-pushed
the
hypeship/windows-networking
branch
from
August 20, 2026 03:07
ab0ea8a to
e3083b1
Compare
sjmiller609
force-pushed
the
hypeship/windows-networking
branch
from
August 20, 2026 14:14
e3083b1 to
78347b4
Compare
sjmiller609
force-pushed
the
hypeship/windows-networking
branch
from
August 20, 2026 15:57
78347b4 to
cb75f89
Compare
sjmiller609
commented
Aug 20, 2026
sjmiller609
commented
Aug 20, 2026
sjmiller609
commented
Aug 20, 2026
sjmiller609
force-pushed
the
hypeship/windows-networking
branch
from
August 20, 2026 17:52
cb75f89 to
336191d
Compare
sjmiller609
force-pushed
the
hypeship/windows-networking
branch
2 times, most recently
from
August 20, 2026 20:25
444f85d to
99d7d11
Compare
sjmiller609
force-pushed
the
hypeship/windows-networking
branch
2 times, most recently
from
August 21, 2026 00:13
38b2708 to
6d78a36
Compare
sjmiller609
marked this pull request as ready for review
August 25, 2026 20:48
sjmiller609
force-pushed
the
hypeship/windows-networking
branch
from
August 25, 2026 20:57
6d78a36 to
eb6f390
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 2 potential issues.
There are 3 total unresolved issues (including 1 from previous review).
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 10ed106. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

summary
targeted tests
The dedicated Windows lifecycle KVM gate and full Linux, Darwin, and install suites pass.
Note
Medium Risk
Changes guest networking on create/start and new Windows IP/route/DNS logic in the guest agent; failures tear down VMs, but misconfiguration could break Windows instance connectivity.
Overview
Windows instances can now use
NetworkEnabledand the same TAP allocation model as Linux, with IPv4, default route, and DNS applied through the guest agent instead of being rejected at create time.The
ReconfigureNetworkRPC gainsdns_servers, and the Windows guest agent implements full reconfiguration via native APIs (adapter lookup by MAC, unicast addresses, routes, andSetInterfaceDnsSettings). Linux keeps the existing shell-command fallback only when the RPC is unimplemented; Windows does not.Create and start treat guest network setup as readiness: after the VM is up, the manager calls
reconfigureGuestNetworkConfigfor Windows; failure stops the instance and fails the operation. Start reapplies allocation when a stopped instance may have a new IP or MAC.CI links Windows fixtures into
/ci/windows, renames the integration gate to Windows lifecycle (TestWindowsLifecycleIntegration), and extends it with networking checks (allocated IP/DNS, RDP on 3389, ICMP). Docs describe the Windows networking model and RDP as reachability through the allocated IP, not a Hypeman API.Reviewed by Cursor Bugbot for commit 0deb5e8. Bugbot is set up for automated code reviews on this repo. Configure here.