Repository navigation
Conversation
`Timezone._expandComponent` only stopped expanding a STANDARD/DAYLIGHT rule at the coverage year. A sub-daily rule, or one whose BY* parts expand into many instances, made any conversion in that zone run practically forever. - A SECONDLY, MINUTELY or HOURLY rule only contributes its DTSTART, taken directly without running the recurrence iterator. Real timezones never change more often than daily. - Expansion stops once a timezone has `Timezone.MAX_CHANGES` (10000) changes. Real zones need far fewer, even starting from 1601. - `_ensureCoverage` now clears `changes` before re-expanding. Each expansion starts over from DTSTART, so extending the coverage to a later year used to append a second copy of every change. Without this, the duplicates would also count against the limit. The new tests hang without the fix.
mkmelin
force-pushed
the
bad-vtimezone-rrule
branch
from
October 15, 2026 10:37
449be47 to
e71b0b1
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Timezone._expandComponentonly stopped expanding a STANDARD/DAYLIGHT rule at the coverage year. A sub-daily rule, or one whose BY* parts expand into many instances, made any conversion in that zone run practically forever.Timezone.MAX_CHANGES(10000) changes. Real zones need far fewer, even starting from 1601._ensureCoveragenow clearschangesbefore re-expanding. Each expansion starts over from DTSTART, so extending the coverage to a later year used to append a second copy of every change. Without this, the duplicates would also count against the limit.The new tests hang without the fix.