Skip to content

Add U.S. Marine Corps leadership principles - #94

Merged
tig merged 18 commits into
mainfrom
cursor/usmc-leadership-principles-ff88
Oct 14, 2026
Merged

tig merged 18 commits into
mainfrom
cursor/usmc-leadership-principles-ff88

Conversation

@tig

@tig tig commented Oct 14, 2026 •

Copy link
Copy Markdown
Member

Add the U.S. Marine Corps as a company set, transcribed from the official TECOM / The Basic School Officership Foundations handout.

https://www.trngcmd.marines.mil/Portals/207/Site%20Images/TBS/B1X0099XQ%20Officership%20Foundations.pdf

Marine Corps University lists the same lesson as RP0103 on the Marine Leader Development page. I linked only official, authorized pages.

Block 10000. Eleven principles, in the numbered doctrine order Marines recite:

  1. Know yourself and seek self-improvement
  2. Be technically and tactically proficient
  3. Know your Marines and look out for their welfare
  4. Keep your Marines informed
  5. Set the example
  6. Ensure the task is understood, supervised and accomplished
  7. Train your Marines as a team
  8. Make sound and timely decisions
  9. Develop a sense of responsibility in your subordinates
  10. Employ your unit in accordance with its capabilities
  11. Seek responsibility and take responsibility for your actions

Definitions are leading excerpts of that handout. I kept the handout's wording, including "supervised and accomplished" without an Oxford comma, "in your subordinates," and "employ your unit." Calibration rows are authored. Every principle sits on a facet with generated rows, so Porridge has a table.

Traits decision

The 14 leadership traits (JJ DID TIE BUCKLE) are not first-class principles in this set.

MCWP 6-10 and the Basic School handout split character from how to lead. "Being of good character is not enough to lead Marines. Men and women of character must learn how to lead. In addition to character, Marine leaders are guided by 11 leadership principles." The traits are the character those principles rest on. A set of 14 trait-principles would be a second model the doctrine does not ask for.

They are further reading on the set. data/teaching/usmc/index.json is the set catalog. Its Further reading list links the official Marine Corps JROTC traits page. There are no per-principle teaching files.

https://www.mcjrotc.marines.mil/About/Leadership-Traits/

Current Leading Marines copy on smmc.marines.mil now lists 15 traits and the mnemonic JJ DID TIE BUCKLEE, adding Empathy. I kept the classic 14 as further reading, because that is the set the issue named and the set the numbered doctrine still teaches.

Facet maps

  • Know yourself and seek self-improvement -> know-yourself (new)
  • Be technically and tactically proficient -> technically-proficient (new)
  • Know your Marines and look out for their welfare -> look-out-for-their-welfare (new)
  • Keep your Marines informed -> keep-them-informed (new)
  • Set the example -> set-the-example (new)
  • Ensure the task is understood, supervised and accomplished -> understood-supervised-and-accomplished (new)
  • Train your Marines as a team -> train-as-a-team (new)
  • Make sound and timely decisions -> are-right-a-lot, bias-for-action
  • Develop a sense of responsibility in your subordinates -> grow-the-team
  • Employ your unit in accordance with its capabilities -> employ-within-capabilities (new)
  • Seek responsibility and take responsibility for your actions -> acts-like-an-owner

know-yourself is new because the curiosity table is new tools and unfamiliar work, not a look at how you lead.

technically-proficient is new because the high-standards table is the quality bar, not craft competence.

look-out-for-their-welfare is new because the help-anyway table is covering work, not knowing people.

keep-them-informed is new because the public-docs table is private versus public files, not giving people enough of the situation to act.

set-the-example is new because the culture table is the room and the hard meeting, not personal example.

understood-supervised-and-accomplished is new because the trio is one loop. The concrete table drops the check. The results table drops the briefing.

train-as-a-team is new because pull-people-together is direction and feedback, not training the handoffs.

employ-within-capabilities is new because the endurance table is personal energy, not matching work to what the unit is trained to hold.

Sound and timely decisions compose the two existing tables. Developing subordinates is the same grow-the-team behavior as Toyota Teamwork. Seeking responsibility is the same owner behavior as Amazon Ownership.

New BIQ questions for Tig

Existing questions covered ten of the eleven principles. Set the example had no fit. These three are new, on set-the-example:

  1. Tell me about a time you asked people for a standard you were not keeping yourself. What did you change first?
  2. Tell me about a time people copied a habit of yours that you did not want copied. What did you do?
  3. Tell me about a time you wanted an exception you would not have given someone else. What did you do?

c6d96f7b stays on that facet so the Examples button has a Junior, Senior, and Exec pack.

Follow-ups

Companion drafts:

Those three are fork PRs from xw-cto because this bot cannot push to those remotes.

Merge this before the BIQ, Porridge, and Facet follow-ups. kindelwww pins come later, only to main commits, after those app PRs merge.

Fixes #93.

Open in Web Open in Cursor 

Claim block 10000 for usmc. Transcribe the 11 principles from the official
TECOM Basic School Officership Foundations handout, in the numbered doctrine
order Marines recite. Calibration rows are authored. Eight new facets cover
behaviors no existing table held. Sound and timely decisions compose
are-right-a-lot and bias-for-action. Developing subordinates maps to
grow-the-team. Seeking responsibility maps to acts-like-an-owner.

The 14 leadership traits stay further reading on the set. Doctrine treats
them as character, not a second principle list.

Co-authored-by: Tig <tig@users.noreply.github.com>
@tig

tig commented Oct 14, 2026

Copy link
Copy Markdown
Member Author

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 14, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-14T10:34:33.635698Z 8d7a384 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 669b1023d8

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread README.md Outdated
cursoragent and others added 2 commits October 14, 2026 04:13
A company addition does not change the explainer. The registry lives in
scripts/companies.py and SCHEMA.md.

Co-authored-by: Tig <tig@users.noreply.github.com>
The 14 leadership traits belong on the set catalog, not in the preamble
URL. data/teaching/usmc/index.json is that catalog. There are no
per-principle teaching files.

Co-authored-by: Tig <tig@users.noreply.github.com>
@chatgpt-codex-connector

Copy link
Copy Markdown

To use Codex here, create a Codex account and connect to github.

@tig

tig commented Oct 14, 2026

Copy link
Copy Markdown
Member Author

@codex review

@tig tig left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Independent review: blocking finding on 8fbe84f. The 669b102 transcription itself is clean.

Summary

The original commit transcribes the 11 principles from the official TECOM / The Basic School Officership Foundations handout (B1X0099XQ) in recitation order, with the handout's wording, including "supervised and accomplished" without an Oxford comma, "in your subordinates," and "employ your unit." Definitions are leading excerpts of whole sentences. The 14 traits stay further reading, not a second principle set. Company id usmc, block 10000, authored calibration, eight new facets plus three composed maps, and BIQ coverage all match AGENTS.md / SCHEMA.md.

Commit 8fbe84f then added data/teaching/usmc/index.json so the traits URL can live on the set catalog. That catalog lists 11 teaching file pointers that are not in the tree. Facet's loader will fail once this catalog is on the principles pin it reads. That is the blocking item below.

Issue counts by severity

  • bugs: 1
  • suggestions: 0
  • nits: 0

Verified

  • Official source: https://www.trngcmd.marines.mil/Portals/207/Site%20Images/TBS/B1X0099XQ%20Officership%20Foundations.pdf (B1X0099XQ). Headings and leading definition sentences match. MCU RP0103 is the same lesson family; it is named in a comment, not linked as a source.
  • Further reading URLs are official: the TBS PDF and https://www.mcjrotc.marines.mil/About/Leadership-Traits/. No unauthorized copies.
  • Traits (JJ DID TIE BUCKLE) are not first-class principles. No trait records, no trait stubs, no trait questions.
  • Every principle has authored rows and generated facet rows. New facets are one table per behavior. Sound and timely decisions compose are-right-a-lot and bias-for-action. Develop subordinates maps to grow-the-team. Seek responsibility maps to acts-like-an-owner.
  • BIQ maps existing question ids first. set-the-example keeps c6d96f7b for the Examples packs and adds three authored questions. Local node scripts/check_facet_questions.js and check_question_ids.js passed.
  • Company id usmc is consistent in the principles index, BIQ bank, porridge stubs, and facet COMPANIES allowlist.
  • Name-only tile. No Eagle, Globe, and Anchor file in biq or porridge css/logos/.
  • Local principles checks on this tree: python3 scripts/validate.py (10 companies, 111 principles, 59 facets) and python3 -m unittest discover -s tests (217 tests) passed. GitHub check on 8fbe84f is green.
  • kindelwww pins and the host copy of allow.js remain follow-up work, as the PR states.

Comment thread data/teaching/usmc/index.json Outdated

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8fbe84f12f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread data/usmc/know-yourself-and-seek-self-improvement.json
The set catalog is Further reading for the 14 traits. The 11 per-principle file pointers were not in the tree, so a missing file could be saved as a second catalog row. A catalog may list no principles, and a listed file has to exist.
@tig

tig commented Oct 14, 2026

Copy link
Copy Markdown
Member Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e47b1a5679

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread data/usmc/make-sound-and-timely-decisions.json
Comment thread data/usmc/develop-a-sense-of-responsibility-in-your-subordinates.json Outdated
Comment thread scripts/validate.py
Move a-decision-that-can-wait onto are-right-a-lot. Its poles are
soundness, not bias-for-action. Rewrite after-they-miss.over so it
does not also withdraw delegation. When a teaching catalog exists,
a principle file has to be listed in it.

Co-authored-by: Tig <tig@users.noreply.github.com>
@cursor

cursor Bot commented Oct 14, 2026

Copy link
Copy Markdown

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

To use Codex here, create a Codex account and connect to github.

@tig

tig commented Oct 14, 2026

Copy link
Copy Markdown
Member Author

@codex review

1 similar comment
@tig

tig commented Oct 14, 2026

Copy link
Copy Markdown
Member Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c30b3088f4

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread data/facets.json Outdated
They copied you used a speech that leaves the habit in place, which is another way of not owning the example. Over now rewrites a sound part of the habit, and they copy that excess.
@tig

tig commented Oct 14, 2026

Copy link
Copy Markdown
Member Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: fef8c1e226

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread data/facets.json Outdated
The over case had switched to public self-auditing, which is the same worry about being seen as the under case. Over now reworks private work past the standard, and the job stays in the room.
@tig

tig commented Oct 14, 2026

Copy link
Copy Markdown
Member Author

@codex review

The generated table now stays in the empty room. The source row still
had the public self-audit over. It now uses the same pole.

Co-authored-by: Tig <tig@users.noreply.github.com>

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b08f5415f3

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread data/usmc/set-the-example.json Outdated
Comment thread data/facets.json Outdated
before-the-work-starts over still skipped the check. It now asks for
another read-back after they already have it. The source row matches.

Co-authored-by: Tig <tig@users.noreply.github.com>
@tig

tig commented Oct 14, 2026

Copy link
Copy Markdown
Member Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@tig tig left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Independent review of 3034c39. Three calibration rows still fail the pole test. The inline comments have the rows.

The two commits after b08f541 are clean. 6fd7ce4 puts the same private rework on the source row when-nobody-is-watching and the generated row the-room-is-empty. 3034c39 makes before-the-work-starts ask for another read-back after they already have it, on the source row and the generated row.

Checked on a temp checkout of this head:

  • python3 scripts/validate.py: 10 companies, 111 principles, 515 rows, 59 facets.
  • python3 -m unittest discover -s tests: 222 tests OK.
  • data/teaching/usmc/index.json lists an empty principles array, and that directory contains only the catalog.
  • Generated rows on the eight new facets match their source rows in situation and pole direction, including the two rows above.
  • Every USMC source row is referenced by the facet listed for that principle. 10008 is split across are-right-a-lot and bias-for-action. 10009 is grow-the-team. 10011 is acts-like-an-owner.
  • Company id usmc matches in scripts/companies.py block 10000, data/index.json, the eleven records, kindel/facet allow.js at 76a30088, kindel/biq questions.json at f154adfe, and the eleven kindel/porridge stubs at d67fb7b9.
  • Facet load() against this principles tree and that BIQ bank comes back ready: 132 items in the usmc filter, the set catalog is fetched, and no per-principle teaching file is requested.
  • Facet tests 162/162 and the allowlist check pass. BIQ facet, id, and search checks pass, plus 25 tests. Porridge 91 tests pass.

No review on facet#17, biq#76, or porridge#73. Those heads still fit this principles head.

Comment thread data/usmc/keep-your-marines-informed.json Outdated
Comment thread data/facets.json Outdated
Comment thread data/usmc/make-sound-and-timely-decisions.json Outdated
Comment thread data/usmc/employ-your-unit-in-accordance-with-its-capabilities.json Outdated
Comment thread data/facets.json Outdated
@tig
tig requested a balanced review from Copilot October 14, 2026 09:38
@tig

tig commented Oct 14, 2026

Copy link
Copy Markdown
Member Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 84396f7a99

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread data/usmc/seek-responsibility-and-take-responsibility-for-your-actions.json Outdated
The quoted definition stopped at seeking assignments. The next two source
sentences name taking responsibility for actions and for what the unit does
or fails to do.

Co-authored-by: Tig <tig@users.noreply.github.com>
@tig

tig commented Oct 14, 2026

Copy link
Copy Markdown
Member Author

@codex review

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Two definitions omit substantial named behaviors that their records and facets model.

0 open findings

Previously missed (2)

In code that hasn't changed since last review

Medium severity Extend excerpt to cover supervision and completion stages

data/​usmc/​ensure-the-task-is-understood-supervised-and-accomplished.json:7

This excerpt defines only the “understood” stage: it stops after communicating instructions and says nothing about supervising the work or confirming accomplishment. Because the record and its dedicated facet model all three stages, consumers receive an incomplete definition of the named principle. Extend the leading source excerpt through whole sentences covering supervision and completion, consistent with the definition contract in SCHEMA.md:251-258.

Medium severity Extend definition to include responsibility for actions

data/​usmc/​seek-responsibility-and-take-responsibility-for-your-actions.json:7

The definition covers seeking challenging assignments but omits the “take responsibility for your actions” half of the principle, even though the rows model ownership of decisions and subordinate outcomes. The declared source continues immediately into taking responsibility, so extend this leading excerpt through those whole sentences to give consumers a complete definition.

🧠 Review effort: Balanced

The quoted definition stopped after communicating instructions. The next
source sentences cover the check before they start and that supervision
is how you know the task is being accomplished.

Co-authored-by: Tig <tig@users.noreply.github.com>

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 0906b2fe88

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread scripts/validate.py
A catalog entry whose file is index.json would pass the existence check
because that path is the catalog. The slug is reserved, and the check
rejects that entry.

Co-authored-by: Tig <tig@users.noreply.github.com>
@tig

tig commented Oct 14, 2026

Copy link
Copy Markdown
Member Author

@codex review

@tig
tig requested a balanced review from Copilot October 14, 2026 10:11

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 78ddbf1e84

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread data/usmc/know-yourself-and-seek-self-improvement.json Outdated
The term names the look at how you lead, not using strengths or fixing
weaknesses. It is a facet on honest-self-assessment and seeking-honest-opinions.

Co-authored-by: Tig <tig@users.noreply.github.com>
@tig

tig commented Oct 14, 2026

Copy link
Copy Markdown
Member Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 3fdf7c1c15

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread data/usmc/ensure-the-task-is-understood-supervised-and-accomplished.json Outdated
The principle name stays the TBS wording. The authored alias now matches
the short form and the style rule.

Co-authored-by: Tig <tig@users.noreply.github.com>

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

One authored term label still violates the repository’s Oxford-comma rule.

0 open findings

Previously missed (1)

In code that hasn't changed since last review

Low severity Use the required Oxford comma in the term label

data/​usmc/​ensure-the-task-is-understood-supervised-and-accomplished.json:11

This authored term label must use the repository's required Oxford comma. The quoted principle name can preserve the source wording, but term labels follow the authored-string style rules.

🧠 Review effort: Balanced

@tig

tig commented Oct 14, 2026

Copy link
Copy Markdown
Member Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8d7a3849eb

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread data/usmc/know-your-marines-and-look-out-for-their-welfare.json Outdated
The excerpt now continues through the next two source sentences: do not
put a nervous Marine in an instant-decision job, and use what you know
of each Marine to choose handling and supervision.

Co-authored-by: Tig <tig@users.noreply.github.com>
@tig

tig commented Oct 14, 2026

Copy link
Copy Markdown
Member Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@tig tig left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Independent review: no blocking findings on 8d7a384

The pull request head moved during this review. 0436726 ("Include the welfare half of Know your Marines") is one commit ahead of 8d7a384, and this comment is on that head. That commit changes one quoted definition. No blocking findings on 0436726 either.

Reviewed against main bf27bfb. The commit on 8d7a384 changes one line in data/usmc/ensure-the-task-is-understood-supervised-and-accomplished.json: the authored alias is now "ensure the task is understood, supervised, and accomplished". The principle name stays the TBS wording. 0436726 then extends the Know your Marines definition through the next two source sentences, ending at "when close supervision is needed." That matches the TBS Officership Foundations paragraph (W1S0007 and B1X0856). The development list that follows, starting with "Put your Marines' welfare before your own," is the same kind of list the other excerpts stop before.

Checked on a detached checkout, push URL disabled:

  • 56 USMC source rows. On each row, under and over are both deficient, they run in opposite directions, and both stay inside the situation. Rows touched in earlier commits still hold: learning-the-craft over-practices the new piece, they-have-questions asks for another read-back after the person already has the task, after-they-miss hands a harder piece without naming the gap, when-nobody-is-watching reworks private work past the standard, bluffing-through walks back a part that still holds, and saying-no-to-the-wrong-work refuses a slice the unit can take.
  • Each source row is referenced once. 10008 splits across are-right-a-lot (estimating-the-situation, a-decision-that-can-wait, revising-a-wrong-call, bluffing-through) and bias-for-action (hesitation, deciding-without-all-the-facts). 10009 is on grow-the-team. 10011 is on acts-like-an-owner. Those four shared facets keep the generated tables from main. The USMC rows there are source refs only.
  • On the eight new facets, the first five generated rows paraphrase the five source rows. Where the sentence is shorter, the behavior is the same, including the updated the-method-has-moved over. The sixth row is an extra situation with its own under and over.
  • data/index.json facet lists match facets.json and tests/fixtures/facet-audit.json. All 11 decisions are map.
  • data/teaching/usmc/ contains only index.json. principles is empty. The catalog names no file. validate.py reserves index for the catalog, and nothing lists index.json as a principle file.
  • Term slices: give-the-why is why-the-work, self-assessment is honest-self-assessment and seeking-honest-opinions, and supervise-the-work is checking-progress and too-much-supervision. The are-right-a-lot and bias-for-action terms list the same rows as the facet refs.
  • python3 scripts/validate.py on 0436726: OK, 10 companies, 111 principles, 515 rows, 59 facets.
  • python3 -m unittest discover -s tests: 224 tests OK.
  • GitHub check on 0436726: SUCCESS. Mergeable, clean. Unresolved review threads: 0.

Companions still fit at the requested heads. No review posted on them.

  • kindel/facet#17 at 82a64e10b7ce78340d0bd232a505594980c1816f allows company id usmc. An empty teaching catalog loads, and this catalog is an empty principles list plus two further-reading links.
  • kindel/biq#76 at 0950e5c60bc1eaca73638b2c8391edf03f03330e has company id usmc with the same ids, slugs, names, and facet lists, and questions left empty. The preamble keeps the traits URL that the teaching catalog also uses.
  • kindel/porridge#73 at 73df0161c8f67bfa585f13ce84210f48f9c81ab3 has 11 stubs plus _index.md. company is usmc, lpId matches the slug, and the title matches the name.

Nothing was pushed, merged, marked ready, or reassigned.

@tig
tig marked this pull request as ready for review October 14, 2026 11:06
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@tig tig self-assigned this Oct 14, 2026
@tig
tig merged commit 194964a into main Oct 14, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add the U.S. Marine Corps leadership principles as a company set

4 participants