Repository navigation
Docs: update docs for API operation histogram and in-flight counter; add dashboard for in-flight operations - #1281
Merged
Conversation
Signed-off-by: James McDermott <james.j.mcdermott@ericsson.com>
…ted) user - nitpick in PackageRevision/PackageRevisions distinction in doc table Signed-off-by: James McDermott <james.j.mcdermott@ericsson.com>
JamesMcDermott
requested review from
a team
and
a balanced review from Copilot
October 13, 2026 16:50
JamesMcDermott
requested review from
efiacor,
kispaljr,
liamfallon and
mozesl-nokia
as code owners
October 13, 2026 16:50
✅ Deploy Preview for kpt-porch ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The new Grafana panel occupies the same grid position as an existing full-width panel.
2 open findings
What changed in this PR
Updates observability documentation and Grafana visualization for metrics introduced by #1198.
Changes:
- Documents expanded API duration and in-flight operation metrics.
- Adds an in-flight operations Grafana panel.
- Updates documented resource-operation mappings.
| File | Description |
|---|---|
docs/content/en/docs/6_configuration_and_deployments/configurations/opentelemetry.md |
Documents metric attributes, names, and operations. |
deployments/metrics-resources/grafana-porch-server-dashboard.json |
Adds the in-flight operations panel. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Signed-off-by: James McDermott <james.j.mcdermott@ericsson.com>
Contributor
|
@netlify rebuild |
Catalin-Stratulat-Ericsson
requested changes
Oct 16, 2026
Catalin-Stratulat-Ericsson
left a comment
Contributor
There was a problem hiding this comment.
just a few minor nitpicks. will review in conjunction with #1198 later as one unit.
Signed-off-by: James McDermott <james.j.mcdermott@ericsson.com>
rendre-greyling
approved these changes
Oct 19, 2026
Catalin-Stratulat-Ericsson
approved these changes
Oct 19, 2026
Catalin-Stratulat-Ericsson
left a comment
Contributor
There was a problem hiding this comment.
good stuff
mozesl-nokia
approved these changes
Oct 22, 2026
4 of 13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Description
porch_api_call_duration_seconds(addedoperation,operation_outcome,lifecycle_after,namespace,repository,package, andworkspace_name)verbattribute as an HTTP-style operation nameporch_in_flight_api_operationsup/down counter and its attributesGETsupport onPackageRevision(porch-controllers,v1alpha2) and a newPackageRevisionApprovalrow (porch-controllers,UPDATE,v1alpha2)Related Issue(s)
Type of Change
Checklist
Testing Instructions (Optional)
make deploy-monitoringporch_in_flight_api_operationsopentelemetry.mddocs page withhugo serve; verify the new "Request Counts - In Flight" section and expanded attribute tables display correctly.AI Disclosure
If so, please describe how: