[dipesh-svg]

What this PR does / why we need it:

Since #2000, SuggestionConfig inlines corev1.Container, so container-level settings (command, args, env, resources, ...) can already be set in the Katib config. Pod-level settings still can't, because DesiredDeployment() only sets serviceAccountName and the resume volume on the Suggestion pod spec. That's why imagePullSecrets, the original ask in #1737, isn't possible today.

This PR adds four optional pod-level fields to SuggestionConfig and copies them to the Suggestion pod spec, as proposed in #1737 (comment):

• imagePullSecrets
• nodeSelector
• tolerations
• affinity

The simple image: setup stays the same, and existing configs behave exactly as before because the fields are only set when present.

Example:

suggestions:
  - algorithmName: random
    image: ghcr.io/kubeflow/katib/suggestion-hyperopt:latest
    imagePullSecrets:
      - name: my-registry-secret
    nodeSelector:
      kubernetes.io/os: linux

Changes:

• pkg/apis/config/v1beta1/types.go: new fields on SuggestionConfig. zz_generated.deepcopy.go was regenerated with controller-gen v0.18.0 (CONTROLLER_GEN_VERSION in the Makefile); the diff only adds these fields.
• pkg/controller.v1beta1/suggestion/composer/composer.go: set the fields on d.Spec.Template.Spec in DesiredDeployment().
• composer_test.go: new TestDesiredDeployment case that sets all four fields and checks the resulting Deployment spec. I checked that the case fails without the composer.go change.

Tested locally with envtest (Kubernetes 1.34.0):

go test ./pkg/controller.v1beta1/suggestion/... ./pkg/util/v1beta1/katibconfig/... ./pkg/apis/config/...
ok  github.com/kubeflow/katib/pkg/controller.v1beta1/suggestion
ok  github.com/kubeflow/katib/pkg/controller.v1beta1/suggestion/composer
ok  github.com/kubeflow/katib/pkg/controller.v1beta1/suggestion/suggestionclient
ok  github.com/kubeflow/katib/pkg/util/v1beta1/katibconfig
ok  github.com/kubeflow/katib/pkg/apis/config/v1beta1

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #1737

Checklist:

• Docs included if any changes are user facing

I'll follow up with a docs PR for the Katib config page on kubeflow/website once the approach looks good.

Assisted-by: Claude

[github-actions]

🎉 Welcome to the Kubeflow Katib repo! 🎉

Thanks for opening your first PR! We're excited to have you onboard 🚀

Next steps:

• Our team will review your PR soon! cc @kubeflow/wg-automl-leads
• Check out the Contributing Guide and the Kubeflow Contributor Guide
• Join the Kubeflow Slack channels: https://www.kubeflow.org/docs/about/community/#kubeflow-slack-channels
• Join the AutoML & Training WG meetings: https://bit.ly/2PWVCkV

Feel free to ask questions in the comments. Thanks again for contributing! 🙏

[google-oss-prow]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign andreyvelich for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[dipesh-svg]

Hi @andreyvelich, could you take a look at this when you have some time? It lets users set pod-level settings for the Suggestion deployment. Happy to change anything.