Repository navigation
Conversation
The status showed normal steps of a start as warnings: the PodInitializing check compared a list to a string and never matched, and any pod condition with a reason, ContainersNotReady included, was a warning. Now only a container that will not start by itself (an error waiting reason, or terminated) and an unschedulable pod are warnings; a running container that is not ready waits for its server. A waiting notebook turns warning when a Warning event seen since its latest condition change explains why it is stuck, so a resolved FailedScheduling no longer counts. Readiness probe failures are part of a start: they do not make a warning, and the latest one completes the waiting message. The notebooks list shares one list of the namespace's Notebook events, listed only when a notebook needs it, and a user who may not list events gets the status without them. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Matteo Bunino <48362942+matbun@users.noreply.github.com>
A notebook pod (Jupyter, VS Code or RStudio) has no readiness probe, so the web app offers Connect as soon as the container starts, before the server listens, and an early click gets "no healthy upstream". The spawner config can now give each server type a readinessProbe (image, imageGroupOne, imageGroupTwo), as mainContainer.readinessProbe does for a WorkspaceKind in Notebooks v2, and the backend copies it onto the container of a new notebook. The default config, in both copies, sets tcpSocket on 8888, where the example images listen. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Matteo Bunino <48362942+matbun@users.noreply.github.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
google-oss-prow
Bot
added
area/frontend
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes: #1551
Two commits. The first shows the steps of a start as waiting: only a container that will not start by itself (an error waiting reason, or terminated), an unschedulable pod, or a Warning event since the latest condition change make a warning. Readiness probe failures are part of a start and complete the waiting message. The list route lists the namespace's Notebook events once, only when needed, and an events error no longer fails it.
The second adds a
readinessProbeper server type to the spawner config, asmainContainer.readinessProbeon a WorkspaceKind in Notebooks v2, applied to new notebooks; the default istcpSocketon 8888. Existing notebooks get no probe, and a custom image not listening on 8888 stays waiting, with the probe failure as the reason.Tested with unit tests and on our cluster (notebook controller 1.10.0, Istio 1.28): notebooks turn ready when the server answers, also with the sidecar, and one stopped while starting shows stopping, then stopped.