Repository navigation
fix(spark): align e2e operator chart with controller - #935
KrishSharma4406 wants to merge 1 commit into
Conversation
Allows hack/e2e-setup-cluster.sh to use SPARK_OPERATOR_CHART_PATH to install the Spark Operator from a local chart path instead of the published chart. In test-spark-examples.yaml, points the chart path to the checkout of kubeflow/spark-operator so that the controller image and its RBAC are kept in sync. Closes kubeflow#933 Signed-off-by: Krish Kumar <krishsharma4406@gmail.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
🎉 Welcome to the Kubeflow SDK! 🎉 Thanks for opening your first PR! We're happy to have you as part of our community 🚀 Here's what happens next:
Join the community:
Feel free to ask questions in the comments if you need any help or clarification! |
|
Thanks @KrishSharma4406 for working on this. #934 was opened earlier for the same issue and is already under review, so I'd prefer to keep the fix consolidated there rather than maintain two overlapping implementations. Your changes around skipping the Helm repo update for local-chart mode and reporting the local chart path are useful, and I've asked for those refinements to be incorporated into #934. Thanks again for picking this up. |
|
Thanks for the contribution @KrishSharma4406! Let me close this in favor of #930 since it covers a much bigger scope and addresses several issues that all need to be resolved together. Would appreciate your reviews on that PR @thisis-Shitanshu and @KrishSharma4406! /close |
|
@tariq-hasan: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What this PR does / why we need it:
The Spark Examples E2E workflow builds the Spark Operator controller image (ghcr.io/kubeflow/spark-operator/controller:local) from current master, but hack/e2e-setup-cluster.sh installed published chart 2.1.0. This causes RBAC drift: the master controller includes spark-operator#3240
requiring networkpolicies create/patch permissions, while chart 2.1.0 lacks them, causing SparkApplication submissions to fail with a 403 error (reported in #933).
Change:
hack/e2e-setup-cluster.sh: Added SPARK_OPERATOR_CHART_PATH support to install from a local Helm chart directory when provided, while preserving the published 2.1.0 chart as the default fallback when unset.
Makefile: Forwarded SPARK_OPERATOR_CHART_PATH through test-e2e-setup-cluster.
.github/workflows/test-spark-examples.yaml: Pointed SPARK_OPERATOR_CHART_PATH to ./spark-operator/charts/spark-operator-chart so the controller image and its Helm chart/RBAC are drawn from the exact same checkout.