Repository navigation
fix(trainer): default to torch-distributed runtime in LocalProcessBac… - #937
Open
harshgupta257 wants to merge 1 commit into
Open
harshgupta257 wants to merge 1 commit into
harshgupta257 wants to merge 1 commit into
Conversation
…kend TrainerClient.train() documents that runtime defaults to the torch-distributed runtime, and the Kubernetes and Container backends do so. LocalProcessBackend instead raised "Runtime must be provided", so the local examples in the quickstart and local development guides, which call client.train(trainer=...) without a runtime, failed. Resolve the default runtime the same way as the other backends. Signed-off-by: harshgupta257 <harshg.pro257@gmail.com>
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
TrainerClient.train()documents thatruntimedefaults to the torch-distributed runtime, and the Kubernetes and Container backends implement that.LocalProcessBackend.train()raisedValueError: Runtime must be provided for LocalProcessBackendinstead, so the local examples in the quickstart and local-development guides (which callclient.train(trainer=...)without a runtime) failed.This resolves the default runtime exactly as the other two backends do:
The unit test case that asserted the error now asserts that training succeeds with the default runtime.
Fixes #936
Testing
make verifypasses.make test-python: 717 passed. The updated test case fails onmainwithout this change.torch-distributedinstead of raising.Checklist
make verifyandmake test-pythonpassThis change was drafted with AI assistance and reviewed, tested, and verified locally by me, per the Kubeflow AI policy.