Skip to content

Kubelet Feature Gates from MD annotations are not going through #534

Open

Description

@CallMeFoxie

Hi
I have got a MachineDeployment object with metadata like this:

metadata:
  annotations:
    v1.kubelet-featuregates.machine-controller.kubermatic.io/DRAConsumableCapacity: "true"
    v1.kubelet-featuregates.machine-controller.kubermatic.io/DRADeviceTaints: "true"
    v1.kubelet-featuregates.machine-controller.kubermatic.io/DRAExtendedResource: "true"
    v1.kubelet-featuregates.machine-controller.kubermatic.io/DRAPrioritizedList: "true"
    v1.kubelet-featuregates.machine-controller.kubermatic.io/DynamicResourceAllocation: "true"
    v1.kubelet-featuregates.machine-controller.kubermatic.io/ResourceHealthStatus: "true"

which is taken from Machine-Controller's code here https://github.com/kubermatic/machine-controller/blob/main/sdk/apis/cluster/common/consts.go#L181 but I cannot find any place where it would be used around here ? https://github.com/kubermatic/operating-system-manager/blob/main/pkg/controllers/osc/resources/operating_system_config.go#L465

am I overlooking something? Because the output kubeletConfig does NOT have these featuregates enabled or even templated in the output OSC.

Thanks
Ashley

Activity

  1. kron4eg commented on Oct 29, 2025

    @kron4eg
    Member

    Looks like you're right, v1.kubelet-featuregates.machine-controller.kubermatic.io is not used in the OSM as in the free-form, we only take predefined feature-gates.

  2. CallMeFoxie commented on Oct 29, 2025

    @CallMeFoxie
    ContributorAuthor

    Glad I have not overlooked something :-)

    I have implemented my own "solution" some time ago, where are all "unknown" v1.kubelet-config.machine-controller.kubermatic.io/whatever are sent into the OSP template as .OtherValues.whatever so I can just update the OSP without having to patch OSM/MC. Meaning I just added v1.kubelet-config.machine-controller.kubermatic.io/featureflags which I unpack in the OSP template myself as a workaround. (We use our own OSP templates as we run a private openstack cloud anyways.)

    Is this something to be fixed and documented or to be cleaned from the code?

  3. kubermatic-bot commented on Jan 27, 2026

    @kubermatic-bot
    Contributor

    Issues go stale after 90d of inactivity.
    After a furter 30 days, they will turn rotten.
    Mark the issue as fresh with /remove-lifecycle stale.

    If this issue is safe to close now please do so with /close.

    /lifecycle stale

  4. added
    lifecycle/staleDenotes an issue or PR has remained open with no activity and has become stale.
    on Jan 27, 2026
  5. kubermatic-bot commented on Feb 27, 2026

    @kubermatic-bot
    Contributor

    Stale issues rot after 30d of inactivity.
    Mark the issue as fresh with /remove-lifecycle rotten.
    Rotten issues close after an additional 30d of inactivity.

    If this issue is safe to close now please do so with /close.

    /lifecycle rotten

  6. added
    lifecycle/rottenDenotes an issue or PR that has aged beyond stale.
    and removed
    lifecycle/staleDenotes an issue or PR has remained open with no activity and has become stale.
    on Feb 27, 2026
  7. kron4eg commented on Feb 27, 2026

    @kron4eg
    Member

    /remove-lifecycle rotten

  8. kubermatic-bot commented on May 28, 2026

    @kubermatic-bot
    Contributor

    Issues go stale after 90d of inactivity.
    After a furter 30 days, they will turn rotten.
    Mark the issue as fresh with /remove-lifecycle stale.

    If this issue is safe to close now please do so with /close.

    /lifecycle stale

  9. added
    lifecycle/staleDenotes an issue or PR has remained open with no activity and has become stale.
    on May 28, 2026
  10. kubermatic-bot commented on Jun 28, 2026

    @kubermatic-bot
    Contributor

    Stale issues rot after 30d of inactivity.
    Mark the issue as fresh with /remove-lifecycle rotten.
    Rotten issues close after an additional 30d of inactivity.

    If this issue is safe to close now please do so with /close.

    /lifecycle rotten

  11. added
    lifecycle/rottenDenotes an issue or PR that has aged beyond stale.
    and removed
    lifecycle/staleDenotes an issue or PR has remained open with no activity and has become stale.
    on Jun 28, 2026
  12. removed
    lifecycle/rottenDenotes an issue or PR that has aged beyond stale.
    on Jun 29, 2026
  13. kubermatic-bot commented on Sep 27, 2026

    @kubermatic-bot
    Contributor

    Issues go stale after 90d of inactivity.
    After a furter 30 days, they will turn rotten.
    Mark the issue as fresh with /remove-lifecycle stale.

    If this issue is safe to close now please do so with /close.

    /lifecycle stale

  14. added
    lifecycle/staleDenotes an issue or PR has remained open with no activity and has become stale.
    on Sep 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    lifecycle/staleDenotes an issue or PR has remained open with no activity and has become stale.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions