[chore]: align Upgrade Academies workflow with Makefile Hugo setup#225
Conversation
Signed-off-by: Lenox Wiltshire <lenoxwiltshire@gmail.com>
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
github-actions
Bot
added
area/learning-paths
area/challenges
area/certifications
labels
|
🚀 Preview deployment: https://layer5io.github.io/academy-theme/pr-preview/pr-225/ |
| token: ${{ secrets.GH_ACCESS_TOKEN }} | ||
| branch: update-academy-theme-${{ github.event.release.tag_name }} | ||
| title: '[Automated] Update academy-theme to ${{ github.event.release.tag_name }}' | ||
| branch: update-academy-theme-${{ github.event.release.tag_name || 'latest' }} |
|
|
||
| Auto-generated based upon release of a new version of layer5io/academy-theme. | ||
| commit-message: Update academy-theme to ${{ github.event.release.tag_name }} | ||
| commit-message: Update academy-theme to ${{ github.event.release.tag_name || 'latest' }} |
There was a problem hiding this comment.
Usage of latest has been removed but for some more context, I added it because on failures, manual runs were being run which resulted in empty PRs so I added it as a safeguard, in my current approach, I'm getting the version directly from the go.mod so if there's any manual runs, the PRs don't end up empty. I can revert this approach back to github.event.release.tag_name if it's desired.
|
|
||
| - name: Install dependencies | ||
| run: | | ||
| cd dependent |
There was a problem hiding this comment.
Why change directories here? This is incorrect.
There was a problem hiding this comment.
Resolved the repo checkout to the root file so there isn't a necessity to change directories to run the makefile recipes
| - name: Install dependencies | ||
| run: | | ||
| cd dependent | ||
| make setup |
There was a problem hiding this comment.
Using the make targets: great.
…inclusion of version variable for manual runs in case of failure Signed-off-by: Lenox Wiltshire <lenoxwiltshire@gmail.com>
Signed-off-by: Lenox Wiltshire <lenoxwiltshire@gmail.com>
|
Test ran successfully. Here's the logs and here's also a screenshot of the run: |
Signed-off-by: Lenox Wiltshire <lenoxwiltshire@gmail.com>
Signed-off-by: Lenox Wiltshire <lenoxwiltshire@gmail.com>
Signed-off-by: Lenox Wiltshire <lenoxwiltshire@gmail.com>
5 participants
This PR fixes #224
*** Notes for Reviewers ***
Signed commits