Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Run:
The command reports that no queue is configured instead of using
database.Expected behavior
When
--queueis omitted, the worker should use thedefaultvalue from the queue configuration.Actual behavior
The worker reports that no queue is configured, even though
MvcConfig('queue')['default']containsdatabase.Proposed solution
In
QueueWorkCommand::resolveQueueConnection(), treat an empty option like an omitted option when selecting the queue:This allows the configured default to be used when Sprout returns an empty string for the missing optional
--queueoption. Explicit queue names continue to take precedence.Environment
leafs/queue: v5.0leafs/sprout: v5