fix(home): address the demo's play/pause messages to our own origin - #45
Merged
Conversation
Both clips are served from public/demo/, so the walkthrough's play and pause messages have no reason to go out to '*'. Addressing them to our origin means nothing is delivered to a frame some other document has managed to navigate elsewhere. Verified on both clips at 1440px and 390px: plays on enter, parks off screen, resumes (desktop reloads) on re-entry — the explicit origin changes nothing about delivery. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #44.
Both walkthrough clips are served from
public/demo/, so the play and pause messages have no reason to go out to'*'. Addressing them towindow.location.originmeans nothing is delivered to a frame that some other document has managed to navigate elsewhere.Verified
Both clips, on Astro 7.2.4: plays on enter, parks off screen, resumes on re-entry (the desktop clip reloads, as #44 explains). The explicit origin changes nothing about delivery.
Gate clean: 0 errors, prettier clean, oxlint clean, knip clean, 75 tests pass.
Note: the CodeQL alerts on
public/demo/**are inside the vendored bundles, not this code, and are unaffected either way.