fix(home): hide the demo bundles' unpack placeholder - #46
Merged
Conversation
Opening the site flashed a blue bolt on a dark card inside the frame — the bundler's own "unpacking" placeholder — before the walkthrough appeared. Measured on a cold frame it was on screen from ~15ms until the bundle swapped the document out. Both bundles now hide #__bundler_thumbnail and the "Unpacking..." pill from their own head style. The wrapper already paints the box, so the frame simply stays empty for those few frames. Nothing in the unpacking script touches either element, and the style disappears with the rest of the placeholder document when it is replaced. This edits vendored artifacts, so the rule carries a comment saying to re-apply it if the bundles are regenerated. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Opening the site flashed a blue bolt on a dark card inside the demo frame before the walkthrough appeared. That is the bundler's own unpack placeholder,
#__bundler_thumbnail— a#1d4ed8rounded rect with a white lightning polygon — shown until the bundle replaces the whole document with the real page. TheUnpacking...pill in the corner is the same thing.Both bundles now hide the two elements from their own head style:
Our wrapper already paints the box, so the frame simply stays empty for those few frames instead of flashing an unrelated icon. Nothing in the unpacking script reads or writes either element, and the injected rule lives in the placeholder document's head — it disappears along with it when
documentElement.replaceWithswaps in the real page, so it cannot affect the walkthrough itself.Measured, before and after
Sampling a cold frame every 5ms and reading the placeholder's computed style:
Both clips still unpack and play: desktop @1440px and phone @390px each reach the real document and keep advancing.
Note
These are vendored artifacts, so the rule carries a comment saying to re-apply it if the bundles are regenerated. Worth folding into the generator instead, if it is easy on that side.
Gate clean: 0 errors, prettier clean, oxlint clean, knip clean, 75 tests pass. The rule ships in
dist/demo/for both bundles.