Repository navigation
Consolidate Julia conversion files and tests - #109
Merged
jswent merged 1 commit intoOct 8, 2026
Merged
Conversation
Combine the six conversion API files into src/to.jl and their test files into test/test_to.jl. Preserve method definitions, docstrings, test bodies, and their existing order, and update the include sites. AI assistance: OpenAI Codex prepared and verified this consolidation. Co-authored-by: Codex <noreply@openai.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #109 +/- ##
=======================================
Coverage ? 73.83%
=======================================
Files ? 21
Lines ? 1586
Branches ? 0
=======================================
Hits ? 1171
Misses ? 415
Partials ? 0 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Julia conversion API and tests are spread across six small files each. Consolidate them into
src/to.jlandtest/test_to.jl, and update the package and test runner includes. Destination headings keep the API easy to navigate. All method definitions, docstrings, test bodies, and execution order are preserved; the C++ files stay separate.Closes #108.
Validation on Julia 1.12.6 / macOS arm64, using the CMake-built local wrapper with libsemigroups 3.6.1:
julia --startup-file=no --project=. test/test_to.jl: 86 passed.julia --startup-file=no --project=. test/runtests.jl: 757,937 passed; 5 existing skips.julia --startup-file=no --project=. test/check_jll.jl: 4 passed against the published JLLs.git diff --checkpasses.AI assistance: OpenAI Codex prepared the consolidation and assisted with validation and review.