fix: read the wrapped compressed-payload envelope

[yeelali14]

Problem

The GitHub trigger is changing the wire format: compressed payloads stop being a bare base64 string and get wrapped in a double-encoded envelope, so that run-name — evaluated before any job or step exists, and therefore unreachable from this action — parses instead of failing the whole workflow at startup.

Live @v2 (2.0.258) mishandles that envelope, and does so silently. We detect compression by sniffing gzip magic bytes on the raw input, so the wrapped form misses the sniff, falls through to the raw branch, and treats the envelope itself as the payload. Measured against the proposed format:

github_token = ""      → checkout falls back to github.token (breaks private/cross-repo)
url          = ""      → git remote add upstream '' fails
has_cm_repo  = "false" → cm repo never checked out → no rules evaluated
                         no setFailed, exit 0

gitStream would appear to run and evaluate nothing.

Change

Parse first, then switch on the value of type.

Matching on the value rather than the presence of type matters: a raw payload can legitimately carry its own type, because Bitbucket builds it from the webhook context. Such a payload must fall through to the raw branch — there's a test for exactly that.

Both compressed forms are permanent, not a migration step. Bitbucket has no run-name to protect and keeps sending the bare base64(gzip) form indefinitely, so neither branch can ever be retired. Supporting both also makes the rollout order-independent: customers pick up @v2 on their own schedule, so the action and the trigger cannot be deployed in a guaranteed order.

A compressed-payload envelope whose data isn't gzip now fails loudly instead of silently resolving to empty fields.

The wrapped compressed tier reports mode=compressed-envelope rather than mode=compressed, so logs distinguish which trigger version produced a run while both formats are in flight.

Verification

All seven wire shapes, plus the malformed envelope:

shape	mode
raw single-encoded	plain
raw double-encoded	plain
raw carrying its own type: 'push'	plain
bare base64(gzip) — Bitbucket, permanent	compressed
wrapped compressed-payload — GitHub, new	compressed-envelope
bare reference — today's format	reference
wrapped reference — GitHub, new	reference
compressed-payload with non-gzip data	fails loudly

19 tests pass (15 before, +4), lint and prettier clean.

Coordination

Format agreed with the trigger side (gitstream-sls-pipeline). Key names are unchanged from #566 — oversized-payload-reference / payloadUrl / resolverToken, plus compressed-payload / data. data is base64(gzip(JSON.stringify(payload))).

The same change is on the two sibling PRs: #568 (v1) and #569 (v2-lite). The trigger side is holding its merge until all three refs can read the new format.

🤖 Generated with Claude Code

✨ PR Description

Purpose: Support wrapped compressed-payload envelopes and improve payload resolution logic to handle multiple compression formats and envelope types.

Main changes:

• Added tryParsePayload() function and COMPRESSED_PAYLOAD constant to handle wrapped compressed envelopes with type detection
• Replaced readStashReference() with unified envelope parsing in resolvePayload() supporting compressed-payload, reference, and plain modes
• Enhanced stashUrl() with explicit URL validation error handling and comprehensive documentation for origin security

Generated by LinearB AI and added by gitStream.
_{AI-generated content may contain inaccuracies. Please verify before using.
💡 Tip: You can customize your AI Description using Guidelines Learn how}

[orca-security-us]

Orca Security Scan Summary

Status	Check	Issues by priority
Passed	Infrastructure as Code	0   0   0   0	View in Orca
Passed	OSS Licenses	0   0   0   0	View in Orca
Passed	SAST	0   0   0   0	View in Orca
Passed	Secrets	0   0   0   0	View in Orca
Passed	Vulnerabilities	0   0   0   0	View in Orca

[linearb]

✨ PR Review

LGTM

Generated by LinearB AI and added by gitStream.
_{AI-generated content may contain inaccuracies. Please verify before using.
💡 Tip: You can customize your AI Review using Guidelines Learn how}

[linearb]

✨ PR Review

The refactor correctly addresses the silent-failure path by parsing first and switching on the envelope type value rather than its presence. The logic is sound, both permanent wire shapes are handled, and the new tests cover all enumerated cases. One minor robustness gap exists in the compressed-payload branch.

1 issues detected:

🐞 Bug - `parsed.data || ''` only replaces falsy values with an empty string; a truthy non-string value (object, number) is forwarded unchanged to `Buffer.from(value, 'base64')`, producing an opaque TypeError instead of the intended descriptive error. 🛠️

Details: When a compressed-payload envelope arrives with a data field that is present but not a string (e.g., a number or a nested object due to a malformed envelope), parsed.data || '' evaluates to that non-string value. inflateIfGzipped then calls Buffer.from(value, 'base64') with a non-string argument, which throws a TypeError from inside Node's Buffer code rather than the intentional "carries no gzip data" error. The PR's own explicit goal is to "fail loudly" in this case, but a TypeError: The "string" argument must be of type string surfaces instead of the descriptive message.

File: scripts/resolve-payload-fields.js (121-121)

_{🛠️ A suggested code correction is included in the review comments.}

Generated by LinearB AI and added by gitStream.
_{AI-generated content may contain inaccuracies. Please verify before using.
💡 Tip: You can customize your AI Review using Guidelines Learn how}

[linearb]

🐞 Bug - Non-string data bypasses descriptive error: Guard the data field to be a non-empty string before passing it to inflateIfGzipped:

const inflated = typeof parsed.data === 'string' && parsed.data
  ? inflateIfGzipped(parsed.data)
  : null

This keeps the null → throw path intact while also covering the non-string case.

Suggested change

	const inflated = inflateIfGzipped(parsed.data || '')
	const inflated = typeof parsed.data === 'string' && parsed.data
	? inflateIfGzipped(parsed.data)
	: null

Is this review accurate? Use 👍 or 👎 to rate it

If you want to tell us more, use /gs feedback e.g. /gs feedback this review doesn't make sense, I disagree, and it keeps repeating over and over

Review dismissed

[yeelali14]

Closed automatically by the branch rename to LINBEE-27157-wrapped-compressed-envelope. Continued in #571 with the same commits (e8cbf69).