nvme: refuse an unsolicited format change on a namespace that is in use - #1123
Open
blktests-ci[bot] wants to merge 1 commit into
Open
nvme: refuse an unsolicited format change on a namespace that is in use#1123blktests-ci[bot] wants to merge 1 commit into
blktests-ci[bot] wants to merge 1 commit into
Conversation
Author
|
Upstream branch: d58772d |
blktests-ci
Bot
force-pushed
the
linus-master_base
branch
from
August 12, 2026 13:27
29ac21d to
ea2c39d
Compare
Author
|
Upstream branch: f5bbbfe |
blktests-ci
Bot
force-pushed
the
series/1144288=>linus-master
branch
from
August 12, 2026 13:50
359de19 to
e0856cc
Compare
blktests-ci
Bot
force-pushed
the
linus-master_base
branch
from
August 12, 2026 18:56
ea2c39d to
4082a30
Compare
Author
|
Upstream branch: 3d6d817 |
blktests-ci
Bot
force-pushed
the
series/1144288=>linus-master
branch
from
August 12, 2026 19:38
e0856cc to
02cdf03
Compare
blktests-ci
Bot
force-pushed
the
linus-master_base
branch
from
August 13, 2026 19:18
4082a30 to
36bd7eb
Compare
Author
|
Upstream branch: 3aa1dca |
blktests-ci
Bot
force-pushed
the
series/1144288=>linus-master
branch
from
August 13, 2026 19:54
02cdf03 to
694d1db
Compare
blktests-ci
Bot
force-pushed
the
linus-master_base
branch
2 times, most recently
from
August 16, 2026 18:34
d89ab11 to
fdba928
Compare
Author
|
Upstream branch: fd923b3 |
blktests-ci
Bot
force-pushed
the
series/1144288=>linus-master
branch
from
August 16, 2026 19:54
694d1db to
4fef557
Compare
blktests-ci
Bot
force-pushed
the
linus-master_base
branch
from
August 17, 2026 14:10
fdba928 to
60442a3
Compare
Author
|
Upstream branch: 8d3ae59 |
A namespace can report a new LBA format or metadata size on revalidation. The host still holds cached data, queued bios and integrity buffers built for the old geometry. Adopting the new one reinterprets all of it. Freezing the queue does not help. The request is already complete when the integrity verify is handed to kintegrityd, so the freeze drains while that work is still pending. The verify then walks a buffer sized for the old metadata_size using the new step size. That is the reported KASAN slab-out-of-bounds read in t10_pi_verify(). Christoph suggested failing such a revalidation rather than handling the fallout. Do that. Compare the new LBA data size and metadata size against the live ones, before the queue is frozen. If they differ while the disk is open, return INVALID_NS/DNR. nvme_validate_ns() turns that into nvme_ns_remove(), as it already does for changed identifiers. Host-initiated format and namespace management are exempt. They arrive through nvme_passthru_end(), where the host asked for the change. NVME_CTRL_SELF_RESCAN marks that window. Link: https://lore.kernel.org/linux-block/ah03bXpgFLQjOUt8@infradead.org/ Link: https://lore.kernel.org/linux-block/20260531-blk-integrity-fix-v1-1-cc7084f42cf1@outlook.com/ Found by FuzzNvme. Signed-off-by: Chao Shi <coshi036@gmail.com>
blktests-ci
Bot
force-pushed
the
series/1144288=>linus-master
branch
from
August 17, 2026 16:42
4fef557 to
b6b19ff
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request for series with
subject: nvme: refuse an unsolicited format change on a namespace that is in use
version: 1
url: https://patchwork.kernel.org/project/linux-block/list/?series=1144288