Skip to content

block: sed-opal: validate response token bounds - #1139

Open
blktests-ci[bot] wants to merge 1 commit into
linus-master_basefrom
series/1145930=>linus-master
Open

block: sed-opal: validate response token bounds#1139
blktests-ci[bot] wants to merge 1 commit into
linus-master_basefrom
series/1145930=>linus-master

Conversation

@blktests-ci

@blktests-ci blktests-ci Bot commented Aug 14, 2026

Copy link
Copy Markdown

Pull request for series with
subject: block: sed-opal: validate response token bounds
version: 2
url: https://patchwork.kernel.org/project/linux-block/list/?series=1145930

@blktests-ci

blktests-ci Bot commented Aug 14, 2026

Copy link
Copy Markdown
Author

Upstream branch: 3aa1dca
series: https://patchwork.kernel.org/project/linux-block/list/?series=1145930
version: 2

@blktests-ci
blktests-ci Bot force-pushed the linus-master_base branch 2 times, most recently from d89ab11 to fdba928 Compare August 16, 2026 18:34
@blktests-ci

blktests-ci Bot commented Aug 16, 2026

Copy link
Copy Markdown
Author

Upstream branch: fd923b3
series: https://patchwork.kernel.org/project/linux-block/list/?series=1145930
version: 2

@blktests-ci
blktests-ci Bot force-pushed the series/1145930=>linus-master branch from 815c1b3 to 3ce94aa Compare August 16, 2026 19:47
@blktests-ci
blktests-ci Bot force-pushed the linus-master_base branch from fdba928 to 60442a3 Compare August 17, 2026 14:10
@blktests-ci

blktests-ci Bot commented Aug 17, 2026

Copy link
Copy Markdown
Author

Upstream branch: 8d3ae59
series: https://patchwork.kernel.org/project/linux-block/list/?series=1145930
version: 2

The OPAL response parser checks the containing subpacket but does
not prove each variable-width token is within that subpacket before
reading its header or payload. It can also append beyond the fixed token
metadata array.

Pass the remaining subpacket length to atom parsers, validate every
header and token extent, check the declared subpacket length against the
supplied response, and reject responses with more than MAX_TOKS tokens.

Fixes: 455a7b2 ("block: Add Sed-opal library")

Assisted-by: Codex:gpt-5
Signed-off-by: Pengpeng Hou <pengpeng@iscas.ac.cn>
@blktests-ci
blktests-ci Bot force-pushed the series/1145930=>linus-master branch from 3ce94aa to eb0a20d Compare August 17, 2026 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant