nvme: fix negative errno passed to libnvme_strerror in get_register_properties - #3728
Merged
igaw merged 1 commit intoAug 5, 2026
Conversation
…roperties libnvme_exec_admin_passthru() can return a negative errno value. Passing that negative value directly to libnvme_strerror(), which expects a non-negative code, produces an incorrect error string. Negate err before passing it to libnvme_strerror() to produce the correct human-readable error string. Signed-off-by: Brooke Ellis <Brooke.Ellis@ibm.com>
Collaborator
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
libnvme_exec_admin_passthru() can return a negative errno value.
Passing that negative value directly to libnvme_strerror(), which
expects a non-negative code, produces an incorrect error string.
Negate err before passing it to libnvme_strerror() to produce the
correct human-readable error string.
Signed-off-by: Brooke Ellis Brooke.Ellis@ibm.com