[BUGFIX] Avoid reading missing fallback config - #470
Merged
lochmueller merged 1 commit intoAug 27, 2026
Conversation
Owner
|
Hey @BenjaminBeck Thanks for the fix. Merged! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description
Avoid reading a fallback cache configuration file when it does not exist or is not readable.
More details
FallbackMiddleware::getCacheConfiguration()currently combines the file checks with||. A missingindex.config.jsontherefore satisfies!is_readable()and is passed toGeneralUtility::getUrl(), which emits a PHP warning before the request continues through TYPO3.Besides producing unnecessary warnings, early error handlers can initialize shared Extbase services before the frontend request is available. On TYPO3 12 this can select the backend configuration manager for the rest of the request, causing cached
USER_INTplugins to fail with exception#1316104317because their controller configuration is empty.This changes the condition to require the configuration file to both exist and be readable, and adds a regression test that converts any warning into an exception.
Tests
USER_INTpluginsCreated by Codex for Benjamin Beck. 🛠️