tickets/SP-3204-review-for-release - #185
Open
sgreenstreet wants to merge 8 commits into
Open
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
jeffcarlin
reviewed
Jul 29, 2026
jeffcarlin
requested changes
Jul 29, 2026
jeffcarlin
left a comment
Collaborator
There was a problem hiding this comment.
Left comments in ReviewNB. The main thing is that I think we should avoid queries that return full tables. Demonstrating to users how to query tables doesn't need the whole thing.
jeffcarlin
approved these changes
Jul 31, 2026
jeffcarlin
left a comment
Collaborator
There was a problem hiding this comment.
Changes all look good -- thanks! Good to merge (looks like you may need to rebase first).
sgreenstreet
force-pushed
the
tickets/SP-3204
branch
from
August 4, 2026 18:19
013d8be to
4e51be3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add 201 series notebooks for
current_identificationsandnumbered_identificationstables.