Skip to content

tickets/SP-3204-review-for-release - #185

Open
sgreenstreet wants to merge 8 commits into
mainfrom
tickets/SP-3204
Open

tickets/SP-3204-review-for-release#185
sgreenstreet wants to merge 8 commits into
mainfrom
tickets/SP-3204

Conversation

@sgreenstreet

Copy link
Copy Markdown
Contributor

Add 201 series notebooks for current_identifications and numbered_identifications tables.

@review-notebook-app

Copy link
Copy Markdown

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@sgreenstreet
sgreenstreet requested a review from jeffcarlin July 27, 2026 23:54

@jeffcarlin jeffcarlin left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left comments in ReviewNB. The main thing is that I think we should avoid queries that return full tables. Demonstrating to users how to query tables doesn't need the whole thing.

@jeffcarlin jeffcarlin left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes all look good -- thanks! Good to merge (looks like you may need to rebase first).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants