lunatik: share the close body between the Lua stop and lunatik_stop - #765
Merged
Merged
Conversation
This was referenced Sep 2, 2026
lneto
force-pushed
the
claude_percpu_tests
branch
from
September 3, 2026 12:46
0721b6f to
0fe50fe
Compare
lneto
force-pushed
the
claude_closeprivate
branch
2 times, most recently
from
September 3, 2026 14:23
d12e0d2 to
86dbd16
Compare
lneto
force-pushed
the
claude_percpu_tests
branch
from
September 3, 2026 14:23
0fe50fe to
5dd79a1
Compare
lneto
force-pushed
the
claude_closeprivate
branch
2 times, most recently
from
September 3, 2026 22:52
e2c98e2 to
067e9ae
Compare
lunatik_stop repeated the body of lunatik_closeobject, detaching the private under the lock and releasing it outside, minus the guard on a private already detached. Move the body to lunatik_closeprivate, so a C caller closes an object the way the Lua stop does, and lunatik_stop is that plus the reference drop. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
lneto
force-pushed
the
claude_closeprivate
branch
from
September 3, 2026 23:01
067e9ae to
eb4a49a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split out of #762, stacked on #764.
lunatik_stoprepeated the body oflunatik_closeobject, detaching the private under the lock and releasing it outside, minus the guard on a private already detached. The body moves tolunatik_closeprivate, so a C caller closes an object the way the Luastopdoes, andlunatik_stopis that plus the reference drop. The percpu object (#762) is the second C caller: itsstopcloses each instance's state without dropping the reference, since the instances stay in place until the object's last reference.Tested on 6.8.0-136 (aarch64): runtime 17/17, clean dmesg.
🤖 Generated with Claude Code