Repository navigation
Conversation
luikyv
requested changes
Aug 24, 2026
luikyv
left a comment
luikyv
left a comment
Owner
There was a problem hiding this comment.
Hey, thanks for taking the time to contribute to this repo. I really appreciate it, this is a nice feature to have in the module
I've requested a few changes. Let me know if anything isn't clear. Feel free to reach out via email or linkedin if you'd like to discuss anything in more detail
This was referenced Oct 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Applications can load current client metadata from their own store without exposing dynamic registration, using
provider.WithClientFuncandgoidc.ClientFunc. Static clients take precedence; DCR and OpenID Federation remain mutually exclusive with the callback.The callback contract requires a non-nil client with the requested ID on success and
goidc.ErrNotFoundonly for unknown clients. Return a fresh snapshot per lookup; fetched JWKS are cached on that snapshot. Implementations reusing client pointers own synchronization and cache invalidation. JWKS fetching and authorization-endpoint error handling retain their existing upstream behavior.Publish RFC 8414 metadata at
/.well-known/oauth-authorization-server{issuer-path}and correct path-based OIDC discovery to{issuer-path}/.well-known/openid-configuration. The previous nonstandard OIDC discovery route is removed for issuers with paths.Verification
Locally verified on 2026-10-08 with Go 1.27.2:
go test ./...go test -race ./internal/client ./internal/discovery ./internal/authorize ./pkg/providergo vet ./...golangci-lint run --new-from-rev=upstream/main(0 issues)git diff --checkTests cover static precedence, fresh client lookups and disablement, lookup error propagation, per-snapshot JWKS caching and key rotation, metadata routes, and disabled dynamic registration.
Full golangci-lint 2.14.0 reports three unchanged baseline findings: two deliberately mixed-case DPoP header tests and the federation example's deprecated
Transport.Dial. Upstream Actions and the conformance suite still need a maintainer-approved run; the original runs expired awaiting approval.References: RFC 8414 and OpenID Connect Discovery 1.0.
Integration check on 2026-10-08: the current heads of #131–#134 merge without conflicts, and
go test ./...passes on their combined tree (c46e03f8823665c0387d317dc9990d1f54095272).