Handle ragged multi-row INSERT in values_dict#661
Closed
santhreal wants to merge 4 commits into
Closed
Conversation
values_dict indexed every row by the first row width, so shorter VALUES tuples raised IndexError. Pad missing cells with None.
Replace per-index padding with zip_longest so short INSERT VALUE rows fill missing columns with None without manual bounds checks.
zip_longest alone sized the dict by the longest VALUES row, dropping declared columns when every row was shorter. Align to len(columns) and cover INSERT ... VALUES (1), (2).
Replace zip_longest transpose with per-column indexing so multi-row and single-row INSERT paths both keep every declared column.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parser.values_dict hits IndexError when INSERT multi-row ragged VALUES (1,2),(3). This PR fixes the regression with a focused test covering the case. claimed