Repository navigation
Conversation
The clients catalog moved to _data/libraries/clients/ in valkey-io/valkey-io.github.io (#602), and the website deploy no longer reads clients/ from this repo. Delete the directory and point the README at the website's add_library pull request template instead. Signed-off-by: Madelyn Olson <madelyneolson@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
clients/directory is no longer read by anything. valkey-io/valkey-io.github.io#602 moved the clients catalog into the website repo, so entries added here never reach valkey.io/clients/, but the README still tells contributors to add them here. This deletesclients/and points the README at the website's add_library pull request template.AI generated details
Problem
valkey-io/valkey-io.github.io#602 (merged 2026-10-27, bb34a34c80753c95f493c1713ee2c83a99d3e3b5) builds
/clients/from_data/libraries/clients/in the website repo. The website deploy reads onlytopicsandcommandsfrom this repo:.github/workflows/zola-deploy.yml:63-64:./build/init-topics.sh ../valkey-doc/topicsand./build/init-commands.sh ../valkey-doc/commands ...README.md:48: "The clients and integrations pages (/clients/,/integrations/) are built from_data/libraries/in this repo, so they need no other repo."README.md:76-103here still describedclients/{language}/{repository}.jsonas the way to get listed. Five PRs following it were closed today: valkey-io#399, valkey-io#413, valkey-io#461, valkey-io#506, valkey-io#507.All 15 JSON entries under
clients/exist in website_data/libraries/clients/, so nothing is lost.Other consumers checked
None found.
clients/. Spellcheck coverstopics/*.mdandcommands/*.mdonly (.spellcheckerrc.yml:1-4).utils/check-links.pl:24,utils/links-to-man.py:63-64andutils/preprocess-markdown.py:255treat../clients/as a link to the generated valkey.io page, not to this directory. Five topics use that link (e.g.topics/introduction.md:32), and the website rewrites it to/clients/(websitetemplates/macros/docs.html:39). Those links stay valid.check-links.plpasses with 0 broken links.valkey-doc/clients,build-clients, orinit-topics-and-clients.shinbuild/,config.toml, templates, workflows, or.gitignore.clients/. Debian packaging installs onlycommands/andtopics/(packaging/common/debian/valkey-doc.install:2-3).clients/.This was generated by AI but verified, with love, by a human.