Skip to content

Compare to the LinkedIn fork #22

Description

@webmaven

LinkedIn has forked Dust.js because the original developer/maintainer isn't responsive.

Given the number of improvements LinkedIn have made, it might be better to compare your compatibility to their fork.

Activity

  1. mahmoud commented on Nov 5, 2014

    @mahmoud
    Owner

    Hehe, definitely, and that's a fair enough point. Last I checked, many/most of LinkedIn's improvements are really just plugins/extensions built in dust, and not actual changes to the language behavior. I have a set of tests dedicated to a few of the most important new features I've pulled over, have a look:

    https://github.com/mahmoud/ashes/blob/master/tests/new_features.py
    https://github.com/mahmoud/ashes/blob/master/tests/comp_helpers.py

  2. webmaven commented on Nov 5, 2014

    @webmaven
    Author

    That's good to know! I suppose What I really meant is making sure you're drawing the comparison in the docs, including the README, to indicate you're maintaining compatibility with the active fork.

  3. jvanasco commented on Jun 23, 2015

    @jvanasco
    Contributor

    Just saw this in the issues list. I had actually done this several months before -- https://github.com/mahmoud/ashes/wiki/Compatibility-with-LinkedIn-Dust.JS-Fork

  4. added a commit that references this issue on Jun 24, 2015
  5. jvanasco commented on Jun 24, 2015

    @jvanasco
    Contributor

    oh there is also a Compatibility file that was pulled into trunk from a PR I made a while back -- https://github.com/mahmoud/ashes/blob/master/COMPATIBILITY.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions