Repository navigation
[fork CI only] Use Log4j 2 configuration in wayang-submit (#536) - #1
Closed
mallesh-bot wants to merge 1 commit into
Closed
mallesh-bot wants to merge 1 commit into
mallesh-bot wants to merge 1 commit into
Conversation
Wayang depends on Log4j 2, but bin/wayang-submit passed the Log4j 1 property -Dlog4j.configuration when FLAG_LOG=true. Log4j 2 ignores that property, and conf/ did not ship a logging configuration, so FLAG_LOG had no effect. Pass -Dlog4j2.configurationFile instead and ship a default conf/log4j2.properties that logs INFO and above to stderr. Because the file lives in the source conf/ directory, the assembly copies it into the distribution and it is no longer lost on a clean install. Generated-by: Claude Opus 5 (Claude Code) Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Owner
Author
|
CI dry run finished (all green). Upstream PR: apache#817 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI dry run inside the fork before opening the upstream PR to apache/wayang. Not for review.
🤖 Generated with Claude Code