fix: resolve config paths from test output#4
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Updates config path resolution to be based on the test/app output directory (AppContext.BaseDirectory) so Default and Shared config lookups work reliably under the test runner (including the ConfigTest family referenced in the PR description).
Changes:
- Resolve
Defaultconfig directory fromAppContext.BaseDirectory. - Resolve
Sharedconfig directory by walking up fromAppContext.BaseDirectoryto locate the repo-levelShareddirectory.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| MapManager.Apis/Config/Shared.cs | Switches Shared directory resolution to be based on the output directory (test/app base directory). |
| MapManager.Apis/Config/Default.cs | Switches Default directory resolution to be based on the output directory (test/app base directory). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+16
to
18
| var outputDirectory = new DirectoryInfo(AppContext.BaseDirectory.TrimEnd(Path.DirectorySeparatorChar, Path.AltDirectorySeparatorChar)); | ||
| var sharedDirectory = new DirectoryInfo(Path.Combine(outputDirectory.Parent.Parent.FullName, "Shared")); | ||
| return sharedDirectory; |
| { | ||
| var assemblyDirectory | ||
| = new DirectoryInfo(Path.Combine(Path.GetDirectoryName(typeof(Version).Assembly.Location) ?? @"./", "Default")); | ||
| var assemblyDirectory = new DirectoryInfo(Path.Combine(AppContext.BaseDirectory, "Default")); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DefaultandSharedconfig paths fromAppContext.BaseDirectory.MapManager.UnitTestsproject onnet48.Verification
dotnet test MapManager.UnitTests/MapManager.UnitTests.csproj --configuration Release --no-build --no-restore --filter FullyQualifiedName~ConfigTestnet48.Fixes mapdojo/Xyzt#171