build(tests): classify MapManager as manual#5
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1a8dda4b9d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
Pull request overview
This PR reclassifies MapManager’s API/integration-style tests as “manual” by moving them into a renamed MapManager.ManualTests project and adjusting project settings so it still builds for compile coverage while being excluded from automated .UnitTests discovery.
Changes:
- Introduces
MapManager.ManualTestsproject (xUnit v3) containing API/version/config sanity checks. - Switches the test project output type from
ExetoLibraryto avoid an executable entry point. - Adds explicit
AssemblyInfo.cs(withGenerateAssemblyInfo=false) for the manual test assembly.
Reviewed changes
Copilot reviewed 1 out of 11 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| MapManager.ManualTests/Properties/AssemblyInfo.cs | Adds explicit assembly metadata for the manual tests project. |
| MapManager.ManualTests/MapManager.ManualTests.csproj | Defines the manual tests project and switches output type to Library. |
| MapManager.ManualTests/Apis/ZLibTest.cs | Adds a manual test asserting ZLib version. |
| MapManager.ManualTests/Apis/ProjTest.cs | Adds a manual test asserting Proj version. |
| MapManager.ManualTests/Apis/Ogr/DriverTest.cs | Adds manual assertions over OGR driver enumeration. |
| MapManager.ManualTests/Apis/MapServerTest.cs | Adds manual tests asserting MapServer version info/support and a couple toggles. |
| MapManager.ManualTests/Apis/GeosTest.cs | Adds a manual test asserting GEOS version. |
| MapManager.ManualTests/Apis/Gdal/DriverTest.cs | Adds manual assertions over GDAL driver enumeration and driver path assignment. |
| MapManager.ManualTests/Apis/FontTest.cs | Adds a manual test asserting font name count. |
| MapManager.ManualTests/Apis/CurlTest.cs | Adds a manual test asserting Curl version. |
| MapManager.ManualTests/Apis/Config/ConfigTest.cs | Adds manual tests asserting Default/Shared config paths. |
Comments suppressed due to low confidence (1)
MapManager.ManualTests/MapManager.ManualTests.csproj:6
- The PR description says
MapManager.UnitTestswas renamed toMapManager.ManualTests, but the solution still referencesMapManager.UnitTests\\MapManager.UnitTests.csproj(and there is noMapManager.UnitTestsdirectory in this branch). This will break building/loadingMapManager.slnunless the.slnis updated to point at the new project.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Review Resolution Summary
|
Summary
MapManager.UnitTeststoMapManager.ManualTestsso Apis.Bake excludes it from automated.UnitTestsdiscovery.Libraryso the renamed xUnit project builds without a generated executable entry point.Verification
dotnet build MapManager.ManualTests/MapManager.ManualTests.csproj --configuration Release --no-restorePart of mapdojo/Xyzt#171