Skip to content

perf(android): convert callbacks directly through JNI - #1856

Merged
mrousavy merged 1 commit into
mrousavy/v1-android-jni-variantsfrom
mrousavy/v1-android-jni-values
Oct 21, 2026
Merged

mrousavy merged 1 commit into
mrousavy/v1-android-jni-variantsfrom
mrousavy/v1-android-jni-values

Conversation

@mrousavy

@mrousavy mrousavy commented Oct 21, 2026 •

Copy link
Copy Markdown
Member

Converts callbacks directly between JSI and the generated Kotlin callback interfaces. The bridge reuses C++ Callback state and retains JNI objects across dispatch. Native C++ interop remains in KotlinCxxCallbackType.

Removes the unused fallback callback generator in this PR. Inline JSI conversion follows separately.

Validation: Nitrogen typecheck and full spec generation. Removing the fallback leaves all generated fixtures unchanged.

@vercel

vercel Bot commented Oct 21, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
nitro-docs Ready Ready Preview Oct 21, 2026 3:31pm UTC

Request Review

@mrousavy
mrousavy force-pushed the mrousavy/v1-android-jni-values branch from b5bece9 to 7d36280 Compare October 21, 2026 00:04
@mrousavy
mrousavy added this pull request to stack #1853 October 21, 2026 00:05
Comment thread packages/nitrogen/src/syntax/kotlin/types/KotlinCallbackType.ts Outdated
Comment thread packages/nitrogen/src/syntax/kotlin/types/KotlinCallbackType.ts Outdated
Comment thread packages/nitrogen/src/syntax/kotlin/types/KotlinArrayType.ts Outdated
Comment thread packages/nitrogen/src/syntax/kotlin/types/KotlinArrayType.ts
Comment thread packages/nitrogen/src/syntax/kotlin/types/KotlinCallbackType.ts Outdated
Comment thread packages/nitrogen/src/syntax/kotlin/types/KotlinCxxRecordType.ts Outdated
Comment thread packages/nitrogen/src/syntax/kotlin/types/KotlinType.ts Outdated
Comment thread packages/nitrogen/src/syntax/kotlin/types/KotlinUnsupportedType.ts
Comment thread packages/nitrogen/src/syntax/kotlin/KotlinCallback.ts Outdated
Comment thread packages/nitrogen/src/syntax/kotlin/wrapKotlinType.ts
@mrousavy
mrousavy force-pushed the mrousavy/v1-android-jni-values branch from 7d36280 to a5b9979 Compare October 21, 2026 11:41
@mrousavy
mrousavy force-pushed the mrousavy/v1-android-jni-values branch from a5b9979 to f59d425 Compare October 21, 2026 11:49
@mrousavy
mrousavy force-pushed the mrousavy/v1-android-jni-values branch from f59d425 to c77cd55 Compare October 21, 2026 12:16
@mrousavy
mrousavy force-pushed the mrousavy/v1-android-jni-values branch from c77cd55 to a8f4044 Compare October 21, 2026 12:30
@mrousavy
mrousavy removed this pull request from stack #1853 October 21, 2026 12:30
@mrousavy
mrousavy added this pull request to stack #1862 October 21, 2026 12:30
@mrousavy
mrousavy force-pushed the mrousavy/v1-android-jni-values branch from a8f4044 to 77ccd53 Compare October 21, 2026 12:48
@mrousavy
mrousavy force-pushed the mrousavy/v1-android-jni-values branch from 77ccd53 to e12495b Compare October 21, 2026 13:32
@mrousavy
mrousavy removed this pull request from stack #1862 October 21, 2026 13:32
@mrousavy mrousavy changed the title feat(android): convert Kotlin values and callbacks directly through JNI perf(android): convert callbacks directly through JNI Oct 21, 2026
@mrousavy
mrousavy changed the base branch from mrousavy/v1-android-jni-handles to mrousavy/v1-android-jni-variants October 21, 2026 13:36
@mrousavy
mrousavy added this pull request to stack #1893 October 21, 2026 13:36
@mrousavy
mrousavy force-pushed the mrousavy/v1-android-jni-values branch from e12495b to 4402f8a Compare October 21, 2026 15:20
@mrousavy
mrousavy removed this pull request from stack #1893 October 21, 2026 15:20
@mrousavy
mrousavy added this pull request to stack #1913 October 21, 2026 15:21
@mrousavy
mrousavy merged commit 2dc49ed into v1 Oct 21, 2026
6 of 42 checks passed

This branch was successfully deployed

1 active deployment
Preview — 4402f8a5 Deployed Oct 21, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant