Skip to content

Adds code to encrypt sensitive values in database to improve security, #PG-5235 - #51

Merged
AltamashShaikh merged 4 commits into
5.x-devfrom
PG-5235-encrypt
Jul 8, 2026
Merged

Adds code to encrypt sensitive values in database to improve security, #PG-5235#51
AltamashShaikh merged 4 commits into
5.x-devfrom
PG-5235-encrypt

Conversation

@AltamashShaikh

Copy link
Copy Markdown
Contributor

Description

Adds code to encrypt sensitive values in database to improve security

Issue No

#PG-5235

Steps to Replicate the Issue

  1. Ensure slack schedule report is setup
  2. checkout this PR
  3. Run core:update
  4. This will encrypt the setting values and running schedule report should send the report too

Checklist

  • [✔] Tested locally or on demo2/demo3?
  • [✔] New test case added/updated?
  • [✔] Are all newly added texts included via translation?
  • [NA] Are text sanitized properly? (Eg use of v-text v/s v-html for vue)
  • [✔] Version bumped?
  • [✔] I have understood, reviewed, and tested all AI outputs before use
  • [✔] All AI instructions respect security, IP, and privacy rules
  • [NA] Documentation updated?

@AltamashShaikh AltamashShaikh added the Needs Review For pull requests that need a code review. label Jul 7, 2026
@AltamashShaikh
AltamashShaikh requested a review from a team July 7, 2026 09:13

@snake14 snake14 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. 👍

I ran the migration locally and confirmed that the token is now encrypted in my DB. AI complained that there wasn't a system test covering the migration script, so not a big deal.

@AltamashShaikh
AltamashShaikh merged commit 22ac258 into 5.x-dev Jul 8, 2026
9 checks passed
@AltamashShaikh
AltamashShaikh deleted the PG-5235-encrypt branch July 8, 2026 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Needs Review For pull requests that need a code review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants