chore(release): candidate v1.7.2 - #396
Conversation
Claude review status
🛠️ Review did not finish Attempted head This round did not publish: MODEL_ACTION_FAILED in phase review_retry. Anything listed below is from the last round that did. Re-run the workflow or push a new commit to try again. |
🧬 Mutation testing — ✅ PASSNothing to test — no mutants were generated on the changed lines. |
🧬 Mutation testingNo results at |
|
Addressed the actionable metadata failure by adding the required PR labels:
The posted review/mutation comments were informational only and had no code changes or questions to answer, so I did not add a reply comment. No commit was created because the worktree had no source changes. Verification passed:
Clippy completed successfully with the existing duplicated MSRV warning. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9ec8e5d410
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| resolver = "2" | ||
| [workspace.package] | ||
| version = "1.7.0" | ||
| version = "1.7.2" |
There was a problem hiding this comment.
Base v1.7.2 on the v1.7.1 release
Publishing this version will regress consumers from the release documented immediately below: the new changelog says v1.7.1 sealed REX6 and opened REX7, but this candidate's sole parent is 30ce038 and its only code change is the version/changelog update; the resulting source still defines REX6 as the newest spec. Since the publish workflow publishes the checked-out tag at this workspace version, v1.7.2 would ship a package that drops the v1.7.1 functionality instead of a patch on top of it. Cut/rebase the candidate from the v1.7.1 release tip before publishing.
Useful? React with 👍 / 👎.
Claude review status
⏭️ Review skipped Not reviewing head This pull request is not a review target: opened by mega-maxwell[bot], the reviewer's own identity. No review round runs for it. Anything listed below is from an earlier round. |
Merging this PR will degrade performance by 9.35%
|
| Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|
| ❌ | rex4/1_txs |
217.6 µs | 246.5 µs | -11.73% |
| ❌ | rex4/deploy_1 |
227.1 µs | 255.4 µs | -11.08% |
| ❌ | mini_rex/5_mixed_txs |
496.7 µs | 542.2 µs | -8.39% |
| ❌ | equivalence/5_mixed_txs |
609 µs | 663.8 µs | -8.26% |
| ❌ | rex4/1_txs |
317.3 µs | 342 µs | -7.22% |
estimated_da_size[0] |
< 1 ns | < 1 ns | N/A | |
estimated_da_size[1000] |
< 1 ns | < 1 ns | N/A | |
estimated_da_size[180] |
< 1 ns | < 1 ns | N/A | |
estimated_da_size[68] |
< 1 ns | < 1 ns | N/A | |
tx_size[0] |
< 1 ns | < 1 ns | N/A | |
tx_size[1000] |
< 1 ns | < 1 ns | N/A | |
tx_size[180] |
< 1 ns | < 1 ns | N/A | |
tx_size[68] |
< 1 ns | < 1 ns | N/A | |
estimated_da_size[0] |
< 1 ns | < 1 ns | N/A | |
estimated_da_size[1000] |
< 1 ns | < 1 ns | N/A | |
estimated_da_size[180] |
< 1 ns | < 1 ns | N/A | |
estimated_da_size[68] |
< 1 ns | < 1 ns | N/A | |
tx_size[0] |
< 1 ns | < 1 ns | N/A | |
tx_size[1000] |
< 1 ns | < 1 ns | N/A | |
tx_size[180] |
< 1 ns | < 1 ns | N/A | |
| ... | ... | ... | ... | ... |
ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing chore/release-candidate-1.7.2 (044aebe) with main (17ca265)3
Footnotes
-
33 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
-
44 benchmarks were run, but are now archived. If they were deleted in another branch, consider rebasing to remove them from the report. Instead if they were added back, click here to restore them. ↩
-
No successful run was found on
release-v1.7.2(30ce038) during the generation of this report, somain(17ca265) was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩
Generated-by: engineer-agent
|
🔧 Pushed CI fixes. Agent log |
|
🔧 Pushed CI fixes. Agent log |
|
Acknowledged. Since this was an intentional skip, I’m leaving the candidate based on |
Release candidate v1.7.2 (was 1.7.0).
Cut from
30ce038cfb0ec108e886ef48105a7ab367a99b33, which is not the tip of the default branch:release-v1.7.2already exists at that commit, and merging this PR puts the version bump and the changelog entry on it. The default branch is left untouched — the next candidate syncs this entry back from the tag.It creates no tag; the tag is cut once, at settlement, by
release-settle→release-publish.Changelog: this release's entry drafted under
## v1.7.2(settle stamps the date on the release branch);previous release's entry synced from its tag: inserted.