fix(evm): load L1 block info at block 0 on release-v1.7.2 - #397
Conversation
Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com> (cherry picked from commit 17ca265)
Claude review status
✅ Review clean Last reviewed: head New this round: 0 finding(s), 0 question(s) · Resolved this round: 0 · Open questions: 0 |
🧬 Mutation testing — ✅ PASSNothing to test — no mutants were generated on the changed lines. |
|
Done, agreed with the rationale here. I replaced |
Codecov Report✅ All modified and coverable lines are covered by tests. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
🧬 Mutation testing — ✅ PASSNothing to test — no mutants were generated (1 unviable, 0 timed out). |
Generated-by: engineer-agent
|
🔧 Pushed CI fixes. Agent log |
|
Thanks, both reports are green. Codecov shows all modified coverable lines covered, and mutation testing reports no generated mutants, so there is no follow-up change needed here. |
Merging this PR will degrade performance by 9.53%
|
| Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|
| ❌ | rex4/1_txs |
217.6 µs | 246.6 µs | -11.78% |
| ❌ | rex4/deploy_1 |
227.1 µs | 256 µs | -11.29% |
| ❌ | mini_rex/5_mixed_txs |
496.7 µs | 543 µs | -8.54% |
| ❌ | equivalence/5_mixed_txs |
609 µs | 664.3 µs | -8.33% |
| ❌ | rex4/1_txs |
317.3 µs | 343.4 µs | -7.62% |
estimated_da_size[0] |
< 1 ns | < 1 ns | N/A | |
estimated_da_size[1000] |
< 1 ns | < 1 ns | N/A | |
estimated_da_size[180] |
< 1 ns | < 1 ns | N/A | |
estimated_da_size[68] |
< 1 ns | < 1 ns | N/A | |
tx_size[0] |
< 1 ns | < 1 ns | N/A | |
tx_size[1000] |
< 1 ns | < 1 ns | N/A | |
tx_size[180] |
< 1 ns | < 1 ns | N/A | |
tx_size[68] |
< 1 ns | < 1 ns | N/A | |
estimated_da_size[0] |
< 1 ns | < 1 ns | N/A | |
estimated_da_size[1000] |
< 1 ns | < 1 ns | N/A | |
estimated_da_size[180] |
< 1 ns | < 1 ns | N/A | |
estimated_da_size[68] |
< 1 ns | < 1 ns | N/A | |
tx_size[0] |
< 1 ns | < 1 ns | N/A | |
tx_size[1000] |
< 1 ns | < 1 ns | N/A | |
tx_size[180] |
< 1 ns | < 1 ns | N/A | |
| ... | ... | ... | ... | ... |
ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing mega-putin/cherry-pick/l1-block0-1.7.2-post396 (fe51a48) with main (17ca265)3
Footnotes
-
33 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
-
44 benchmarks were run, but are now archived. If they were deleted in another branch, consider rebasing to remove them from the report. Instead if they were added back, click here to restore them. ↩
-
No successful run was found on
release-v1.7.2(a08ccfa) during the generation of this report, somain(17ca265) was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩
|
❓ CodSpeed is failing because it compared this (I've paused on this task. Reply here with the answer and I'll continue where I left off.) |
Summary
Cherry-pick
17ca265bcf97f8f998c71a5123cfb09979bae270(fix(evm): load L1 block info for transactions at block 0, mega-evm #392) ontorelease-v1.7.2after the candidate bump (#396).Main already has this. The 1.7.2 line did not.
Replaces closed #395, which targeted the pre-force-update
release-v1.7.2tip.factory.rsconflicted because 1.7.2's tests module is not the same as main. Resolution:L1BlockInfo.l2_block = U256::MAXso block 0 reloads L1 info from state.test_external_env_factory_getter.test_non_deposit_tx_at_block_zero_loads_l1_block_info_from_state.test_dyn_precompiles_builder_receives_the_behavior_spec(not on this line).Test plan
release-v1.7.2crates/mega-evm/src/evm/factory.rschanged besides cherry-pick metadata