Repository navigation
Infra: CI GitHub Actions + séparation des tests matériel (#18) - #26
Closed
mickaelbegon wants to merge 3 commits into
Closed
mickaelbegon wants to merge 3 commits into
mickaelbegon wants to merge 3 commits into
Conversation
Hardware tests are skipped unless --port or PYSCIENCEMODE_PORT is given; electrode-removal tests also need --run-interactive. Replaces the hard-coded COM3/COM4 ports with a port fixture. Also replaces the obsolete 'Please indicate the stimulation duration' test (the duration is now optional) with a check of the current TypeError on an invalid type. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…, py3.10-3.12) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Owner
Author
|
Déplacée sur upstream : s2mLab#27 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #18
Contenu
Séparation des tests matériel (
tests/conftest.py)--port(ou variable d'environnementPYSCIENCEMODE_PORT) + fixtureportqui remplace lesCOM3/COM4codés en dur.hardware,p24,rehastim2(posés viapytestmarkau niveau module) : les tests matériel sont skippés par défaut sans port.interactivepour les tests d'erreur d'électrode (nécessitent de débrancher une électrode pendant le test) : ne tournent qu'avec--run-interactive.conftest.py(aucune modification depyproject.toml, pour ne pas entrer en conflit avec Infra: packaging unifié (pyproject unique, extra [p24], nettoyage du dépôt) #19).Exemples :
Test obsolète (
tests/test_raise_error_p24.py)test_no_stimulation_duration_errorattendait « Please indicate the stimulation duration », message qui n'existe plus :stimulation_durationest désormais optionnel dansP24.start_stimulation. Remplacé partest_invalid_stimulation_duration_type_error, qui vérifie leTypeErroractuel (« Please provide a int or float type for stimulation duration »).Smoke tests sans matériel (
tests/test_no_hardware.py)ChannelP24/Rehastim2, limites,calc_electrode_number,check_pulse_interval_list). Volontairement évités : les points couverts par Bug: validation Channel (set_frequency, aliasing des Points en doublet/triplet) #16.CI (
.github/workflows/ci.yml)ruff checkavec un jeu de règles volontairement minimal (E9,F63,F7,F82) pour passer aujourd'hui ; à durcir plus tard.pytest tests(sans matériel) sur ubuntu / windows / macos × Python 3.10, 3.11, 3.12, installation viapip install -e . pytest.sciencemode_cffi(Windows cp310 uniquement) n'est pas installée : les tests qui en dépendent sont des tests matériel, donc skippés.Vérifié localement (Windows, Python 3.11)
pytest tests: 8 passed, 47 skipped.ruff check --select E9,F63,F7,F82 .: OK.--portfictif, les tests matériel sont bien exécutés (et échouent sur leNameError: sciencemodedécrit dans Bug: import silencieux de sciencemode (NameError tardif) #17 quand la lib P24 est absente).🤖 Generated with Claude Code