Conversation
Member
Not wasting time on this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Align the prefix-star fast path with the full parser for an optional trailing slash. With default options,
isMatch('foo/', 'foo*')returnedfalse, whilefastpaths: falsereturnedtrue. The existing*behavior already acceptsa/unlessstrictSlashesis enabled.The fast path now adds the optional slash only when its generated expression ends in an unescaped star. Escaped stars,
strictSlashes: true, and paths with an additional segment keep their behavior.This addresses the secondary fast-path divergence noted in #207. PR #208 handles the separate
*.*case.Reproduction and verification
0 passing, 1 failingatassert(isMatch('foo/', pattern)).npx mocha test/stars.js --reporter dot: 18 passing.npm run mocha -- --reporter dot: 1999 passing.npm run lintandgit diff --check: passed.fastpaths: falsefor the affected patterns under default,strictSlashes,capture,bash, and Windows options: no remaining differences in the checked cases.Prepared with OpenAI Codex assistance. The change has not yet received human review.