Fix endless loop if index set is nil

[Felipe A Rodriguez (xFAR)]

Raises an invalid arg exception per Apple implementation and docs.

---

This change is 

[Dustin L. Howett (MSFT) (DHowett-MSFT)]

Hi Felipe A Rodriguez (@xFAR)! Thanks for the contribution.

I'd like to accept this pull request, but I've got a couple minor issues:

• Our coding convention requires four spaces be used per indentation level than one tab
• We have a macro (admittedly difficult to discover!) called NS_COLLECTION_THROW_IF_NULL_REASON; you can place it at the top of this function and keep the rest of the code the same.

NS_COLLECTION_THROW_IF_NULL_REASON(indexes, @"indexes must not be nil");

Would you mind writing tests (in NSArrayTests.mm) for this method (with a nil index set) as well? You can use the other tests as a template.

[Felipe A Rodriguez (xFAR)]

Dustin, My responses inline.

On Jul 21, 2017, at 1:08 AM, Dustin L. Howett (MSFT) ***@***.***> wrote: @DHowett-MSFT requested changes on this pull request. Hi @xFAR! Thanks for the contribution. I'd like to accept this pull request, but I've got a couple minor issues: Our coding convention requires four spaces be used per indentation level than one tab

I will update the style. I use tabs equal to four spaces so I did not notice.

We have a macro (admittedly difficult to discover!) called NS_COLLECTION_THROW_IF_NULL_REASON; you can place it at the top of this function and keep the rest of the code the same. NS_COLLECTION_THROW_IF_NULL_REASON(indexes, @"indexes must not be nil”);

Ok.

Would you mind writing tests (in NSArrayTests.mm) for this behaviour as well? You can use the other tests as a template.

Hopefully, I can get to this later in the week.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

Regards, Felipe A. Rodriguez illumenos LLC

…

________________________