Modernize stable samples for Windows App SDK 2.4 - #664
Merged
Merged
Conversation
Port the proven release/experimental framework and package updates to main while preserving samples that exercise version-pinned experimental APIs. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 26f0def2-a93d-4d41-a610-c6c6fa760d7e
Keep experimental and preview sample implementations on the dedicated release/experimental branch so main contains only stable Windows App SDK surfaces. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 26f0def2-a93d-4d41-a610-c6c6fa760d7e
Remove per-profile ReadyToRun opt-ins that are incompatible with the .NET 8 sample restore and cause NETSDK1094 in aggregator compatibility builds. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 26f0def2-a93d-4d41-a610-c6c6fa760d7e
Add the Windows App SDK 2.4 component closure to native packages.config projects and their generated MSBuild imports. Default explicit C++ toolsets to v145 while retaining a v143 fallback for Visual Studio 2022. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 26f0def2-a93d-4d41-a610-c6c6fa760d7e
Use AbiWinRTSDKReferences with the resolved Windows SDK directory and target version instead of a drive-specific Windows.winmd path. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 26f0def2-a93d-4d41-a610-c6c6fa760d7e
Remove stale sample ReadyToRun profile overrides so pipeline restore and publish properties remain consistent. Resolve WindowsML ABI metadata through the normalized Windows SDK target version used by MSBuild. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 26f0def2-a93d-4d41-a610-c6c6fa760d7e
Scott Jones (Scottj1s)
marked this pull request as ready for review
August 27, 2026 11:47
agniuks
approved these changes
Aug 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
win-*runtime identifierspackages.configprojectsmain; they remain onrelease/experimentalValidation
d2bcd2ff; SamplesCompatTest and BuildPerformanceTest completed without errors