fix: skip literal preflight for git semver ranges - #2590
Draft
Aryan Singh K. (aryansk) wants to merge 1 commit into
Draft
fix: skip literal preflight for git semver ranges#2590Aryan Singh K. (aryansk) wants to merge 1 commit into
Aryan Singh K. (aryansk) wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Let git semver constraints from positional
apm installreach the existing semver resolver instead of probing the raw range string as if it were a literal Git ref. Registry-backed references retain their existing validation path, and exact refs still use normal preflight probing.Testing
Added regression coverage asserting that a virtual-subdir semver range skips
_validate_package_existsand remains eligible for downstream resolution.Fixes #2514