Add CMake build to repo, integrate with CI - #2791
Open
Hamza El-Saawy (helsaawy) wants to merge 1 commit into
Open
Add CMake build to repo, integrate with CI#2791Hamza El-Saawy (helsaawy) wants to merge 1 commit into
Hamza El-Saawy (helsaawy) wants to merge 1 commit into
Conversation
Hamza El-Saawy (helsaawy)
force-pushed
the
cmake
branch
2 times, most recently
from
June 24, 2026 18:29
0af219c to
9fd47ad
Compare
| securitypolicy | ||
| uvmboot.exe | ||
| zapdir.exe | ||
| ${{ github.workspace }}/out/x64-release/bin/* |
Contributor
There was a problem hiding this comment.
Err. I like the explicit list personally. We dont want to publish every bin right?
Contributor
Author
There was a problem hiding this comment.
i thought we did try to update it with new binaries to, at the very least, verify they build without issue?
| exit $LASTEXITCODE | ||
| } | ||
|
|
||
| protos: |
Use CMake to codify common repo actions (e.g., go module dependency management, code gen, linting, building). Currently initial sketch/outline of work, focused on Golang on Windows and integrating with the GH CI; will need to add C binaries, building on Linux, integrating with the (Linux) Makefile for building the rootfs, running tests, better tracking of proto source files, compiling manifests, etc. Add `cmake\FindGo.cmake` to check that Golang (and `golangci-lint`) is available. Update default version used by `scripts/New-ResourceObjectFile.ps1` to `0.0.1` instead of `1.0.0`, and downgrade errors about missing VERSION file to warnings, since GH CI does not checkout git tags. Rather than calling `New-ResourceObjectFile.ps1` with `go generate` and therefore always (re)create the object files, generate them instead as needed using CMake dependencies. Signed-off-by: Hamza El-Saawy <hamzaelsaawy@microsoft.com>
Hamza El-Saawy (helsaawy)
force-pushed
the
cmake
branch
from
August 4, 2026 18:25
81d1602 to
11b1bd9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use CMake to codify common repo actions (e.g., go module dependency management, code gen, linting, building).
Currently initial sketch/outline of work, focused on Golang on Windows and integrating with the GH CI; will need to add C binaries, building on Linux, integrating with the (Linux) Makefile for building the rootfs, running tests, better tracking of proto source files, compiling manifests, etc.
Add
cmake\FindGo.cmaketo check that Golang (andgolangci-lint) is available.Update default version used by
scripts/New-ResourceObjectFile.ps1to0.0.1instead of1.0.0, and downgrade errors about missing VERSION file to warnings, since GH CI does not checkout git tags.