Fix structure of EpLibraryPlugin::Load so that we call Unload on error.#29634
Open
skottmckay wants to merge 2 commits into
Open
Fix structure of EpLibraryPlugin::Load so that we call Unload on error.#29634skottmckay wants to merge 2 commits into
skottmckay wants to merge 2 commits into
Conversation
skottmckay
requested review from
Copilot and
edgchen1
and removed request for
edgchen1
Contributor
There was a problem hiding this comment.
Pull request overview
This PR restructures EpLibraryPlugin::Load() to ensure that a partially loaded EP plugin library is cleaned up on any failure (returned error Status as well as exceptions), instead of only on exceptions.
Changes:
- Wraps the library load sequence in an inner lambda so
ORT_RETURN_IF_ERRORproduces an errorStatuswithout returning fromLoad(). - Adds a unified failure-path cleanup block intended to call
Unload()on any non-OKstatus.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix structure of EpLibraryPlugin::Load so that we call Unload on any error and not just an exception.
Currently we directly return on error so the Unload is never hit.
Motivation and Context
Cleanup failed load fully.