Fix #11263: Make Edit Configurations UI fully theme-aware in custom themes - #14692
Fix #11263: Make Edit Configurations UI fully theme-aware in custom themes#14692Prashant Kumar Rai (8prashant) wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the Edit Configurations webview to better follow VS Code theme colors.
Changes:
- Adds reusable theme-token fallbacks.
- Themes editable selects, page backgrounds, code blocks, and links.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
3b0ac9c to
f1fe7c8
Compare
|
Hi Sean McManus (@sean-mcmanus)
Can u please re-review the PR!! |
Sean McManus (sean-mcmanus)
left a comment
There was a problem hiding this comment.
One user-facing dropdown-affordance regression remains on the current head.
| margin: auto; | ||
| color: var(--vscode-settings-textInputForeground); | ||
| background: var(--vscode-settings-textInputBackground); | ||
| color: transparent; |
There was a problem hiding this comment.
✨Copilot (agent148): [Moderate] color: transparent also makes Chromium's native select chevron transparent because the arrow is painted from the control's current color. Both editable controls therefore lose their visible dropdown affordance; the arrow is absent in the supplied after screenshot as well as in a focused Chromium reproduction. Please suppress only the selected text while preserving color for the native control, for example by using transparent text fill and restoring it on option, or another arrow-preserving approach.
This PR fixes theming issues in the C/C++ Edit Configurations UI so it renders correctly with custom themes such as Bearded Theme.
Fixes #11263
Problem
The Edit Configurations UI had incomplete theming behavior:
Fix
Validation
Screenshots
Before
Top area:

Full page:

After
Top area:

Full page:
