Skip to content

feat: Add support for all rlp.Serializable derived transactions #49

Open
Open
feat: Add support for all rlp.Serializable derived transactions#49
Labels
enhancementNew feature or request

Description

@mikeshultz
mikeshultz
opened on Oct 3, 2023

Right now most of our funcs check for native-types. For example:

ledger-eth-lib/ledgereth/transactions.py

Lines 51 to 60 in 884a25b

if isinstance(tx, Transaction):
encoded_tx = encode(tx, Transaction)
elif isinstance(tx, Type1Transaction):
encoded_tx = tx.transaction_type.to_byte() + encode(tx, Type1Transaction)
elif isinstance(tx, Type2Transaction):
encoded_tx = tx.transaction_type.to_byte() + encode(tx, Type2Transaction)
else:
raise ValueError(
"Only Transaction and Type2Transaction objects are currently supported"
)

Look into supporting any rlp.Serializable objects to allow for easier integration. May need to validate the objects for the necessary props/types (Python Protocols could be useful?) to make sure but it should be doable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions