NamedSelector::translateToXPath error on 'content' selector

[mloureiro]

Hi there!

I'm new in Behat so it might be something I'm doing wrong.
So doing:

$selector = new \Behat\Mink\Selector\NamedSelector();
$xpath = $selector->translateToXPath( array( 'content', "a string here" ) );

will lead to:

 Unknown named selector provided: "./descendant-or-self::*[contains(normalize-space(.), omgomgogm)]". Expected one of (fieldset, field, link, button, link_or_button, content, select, checkbox, radio, file, optgroup, option, table)

Also doing:

$page->find( 'named', array( 'content', "a string here" ) );

will lead to:

      error:_sahi.setServerVarPlain('___lastValue___52499ba54203f', (function(){
          var count = 0;
          while (_byXPath("(//html/./descendant-or-self::*[contains(normalize-space(.), a string here)])["+(count+1)+"]")) count++;
          return count;
      })())
      SyntaxError: The expression is not a legal expression.
      No trace available
      <a href='/_s_/dyn/Log_getBrowserScript?href=null&n=1601'><b>Click for browser script</b></a>

Thanks

[stof]

@everzet I think the NamedSelector should take care of escaping the xPath literal used as locator. I don't see any valid reason to allow passing arbitrary XPath there, and lots of reason to make it simple to use.

@mloureiro the way to make it work currently is to use the following code:

$escapedText = $session->getSelectorsHandler()->xpathLiteral('a string here')
$page->find('named', array('content', $escapedText));

[stof]

Btw, this is exactly what is done currently in all places needing to use the selectors. I think this is a bad design as it is not the responsibility of elements to escape the locator as XPath (I don't see why they should be aware that XPath is used by the NamedSelector to find elements)

[aik099]

👍 for moving escaping to selector class, when non-xpath expression coming in as input

[stof]

The issue with this change is that it is a BC break (any code calling the selectors API currently has to take care of the escaping, and it would double escape literals then)

[mloureiro]

@stof Thanks, :)
And 👍 for the selector taking care of escaping