Pin the hasura image to a commit SHA instead of latest - #107
Merged
Conversation
The chart asked for ghcr.io/mintproject/graphql-engine:latest, but the graphql_engine workflow publishes only :main and :<full-sha>. It has never pushed :latest, so that tag is a stale image no merge updates -- it matches none of the last six commits on main, and carries neither the indicator FK migration (mintproject/monorepo#106) nor the cascade migration (mintproject/monorepo#99). pullPolicy: Always cannot help when the tag itself never moves. Pin 06492bd, the merge of mintproject/graphql_engine#15. Migrations are baked into this image, so the tag decides which schema a deployment can reach at all. Same treatment model_catalog_api got in #106.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
components.hasura.image.tagwaslatest. Thegraphql_engineworkflow does notpublish that tag. From the merge build's own log:
:mainand:<full-sha>only. So:latestis a stale image that no merge updates, andpullPolicy: Alwayscannot help when the tag itself never moves.Measured against the registry —
:latestmatches none of the last six commits onmain:mainsha256:1f3a4070…06492bde…(this pin)sha256:1f3a4070…latest(what the chart used)sha256:970311f3…c274ce0sha256:208b1145…0d74aa1sha256:fadb2448…Why it matters more for hasura than for other components
Migrations are baked into the image. The tag therefore decides which schema a deployment
can reach at all —
hasura migrate applycan only apply what the running image carries.On
:latestthe chart could not deliver either of the last two schema changes:1771200018000_response_variable_standard_variable_fk— Variables step cannot save any indicator: it writes a standard-variable URI into a column that references the legacy variable table monorepo#106, theindicator foreign key
1771200017000_modeling_provenance_cascade_on_delete— Deleting a problem statement, task or thread leaves the row behind and reports success monorepo#99What this is
Pin
06492bd, the merge of mintproject/graphql_engine#15. Same treatmentmodel_catalog_apigot in #106. Chart version9.0.0-beta.4→9.0.0-beta.5, READMEregenerated to match.
Verified
helm lintclean.helm templaterenders the new tag in both places that consume it —the
mint-hasuraDeployment and themint-hasura-post-installJob.Not fixed here
mint-ui-lit(values.yaml:380) andensemble-manager(values.yaml:465) are also onlatest. I have not checked what those pipelines publish, so they are left alone.The post-install Job is still
helm.sh/hook: post-installwith nopost-upgrade, so anupgrade still does not run migrations — that is mintproject/monorepo#117, unchanged by this PR.