feat(images): make global.imageTag reach the four single-repo services - #110
Merged
Conversation
global.imageTag had no effect. Every one of the four services it names carried a non-empty tag in the chart defaults, and a per-service tag wins. A fresh install with --set global.imageTag=X resolved the old pinned SHAs instead. Clear the four default tags so the global value applies, and default global.imageTag to 0.1.0, the first mintproject/monorepo release. An empty default would fall through to .Chart.AppVersion (1.16.3), which names no image these services publish. Move ui_react and ensemble_manager to GHCR. Both still pointed at Docker Hub, which the single repo no longer publishes to. Package as 9.0.0-beta.8. Verified by rendering: - a bare install resolves all four to ghcr.io/mintproject/<image>:0.1.0 - --set global.imageTag=X reaches all four - a per-service image.tag still overrides the global value - cromo, mic, data_catalog, model_catalog_endpoint, model_catalog_explorer, ui (mint-ui-lit), postgres and postgis are unchanged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
global.imageTagwas added in #109 but has no effect. Every one of the four services it names carries a non-emptytagin the chart defaults, and a per-service tag wins over the global value.Rendering 9.0.0-beta.7 the way the cutover runbook specifies:
Zero of four picked up the tag.
What this changes
hasura,model_catalog_api,ui_react,ensemble_manager— soglobal.imageTagapplies.global.imageTagto0.1.0, the firstmintproject/monoreporelease. An empty default falls through to.Chart.AppVersion(1.16.3), which names no image these services publish, so a bare install would break.ui_reactandensemble_managerto GHCR. Both still pointed at Docker Hub. The single repo does not publish there, and neither Docker Hub repo has a0.1.0tag.9.0.0-beta.8.Verification
A bare install — no overrides at all — now resolves:
Also rendered:
--set global.imageTag=9.9.9reaches all four.--set components.hasura.image.tag=PINNEDstill overrides the global value, so the escape hatch is intact.cromo,mic_ui,mic_api,data_catalog,data_catalog_db,model_catalog_endpoint,model_catalog_explorer,ui(mint-ui-lit),postgresandpostgisare unchanged.helm lint: 0 failed.helm upgrade --dry-runagainst the MicroK8s dev cluster: rc=0.Impact on existing consumers
Additive.
dynamoand the forks override every tag per service, so nothing changes for them until they choose to drop those overrides.README.mdis regenerated with helm-docs 1.14.2.index.yamlis regenerated bymake release, which rewrites thecreatedtimestamps — the same churn as #109.Follow-up, not in this PR
appVersionis still1.16.3, a leftover fromhelm create. The documented fallback chain ends there, so it is worth setting to a real MINT version.