Skip to content

fix: the tools/view in view.js #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
anupamme wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: the tools/view in view.js #11

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 15 additions & 12 deletions tools/view.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,13 @@ if (!exampleFile) {
// Resolve the full path
const fullPath = path.resolve(exampleFile);

// Restrict access to the examples directory only
const examplesDir = path.resolve(__dirname, "..", "examples");
if (!fullPath.startsWith(examplesDir + path.sep)) {
console.error(`Error: File must be within the examples/ directory`);
process.exit(1);
}

if (!fs.existsSync(fullPath)) {
console.error(`File not found: ${fullPath}`);
process.exit(1);
Expand Down Expand Up @@ -146,20 +153,16 @@ async function buildAndServe() {
console.log("Build successful!");

// Create a simple HTTP server
// Pre-build allowed paths to avoid any user-input in path construction
const servedFiles = {
"/": path.join(tempDir, "index.html"),
"/bundle.js": path.join(tempDir, "bundle.js"),
"/bundle.js.map": path.join(tempDir, "bundle.js.map"),
};
const server = http.createServer((req, res) => {
let filePath = path.join(
tempDir,
req.url === "/" ? "index.html" : req.url,
);

// Security: prevent directory traversal
if (!filePath.startsWith(tempDir)) {
res.writeHead(403);
res.end("Forbidden");
return;
}
const filePath = servedFiles[req.url];

if (!fs.existsSync(filePath)) {
if (!filePath || !fs.existsSync(filePath)) {
res.writeHead(404);
res.end("Not found");
return;
Expand Down